PR feedback

- Use `Sequence` instead of `List`
- Add note
- Remove redundant words in docstring
This commit is contained in:
mhchia
2019-09-04 20:49:14 +08:00
parent db0da8083a
commit 0e3d4508d6
3 changed files with 7 additions and 6 deletions

View File

@ -1,4 +1,4 @@
from typing import List
from typing import List, Sequence
import multiaddr
@ -10,9 +10,9 @@ class PeerInfo:
peer_id: ID
addrs: List[multiaddr.Multiaddr]
def __init__(self, peer_id: ID, addrs: List[multiaddr.Multiaddr]) -> None:
def __init__(self, peer_id: ID, addrs: Sequence[multiaddr.Multiaddr]) -> None:
self.peer_id = peer_id
self.addrs = addrs
self.addrs = list(addrs)
def info_from_p2p_addr(addr: multiaddr.Multiaddr) -> PeerInfo: