Refactor logging code: Remove unnecessary blank lines in logging setup and cleanup functions for improved readability. Update tests to reflect formatting changes.

This commit is contained in:
yashksaini-coder
2025-09-02 01:39:24 +05:30
parent 84c1a7031a
commit 145727a9ba
3 changed files with 14 additions and 12 deletions

View File

@ -180,10 +180,10 @@ async def test_custom_log_file(clean_env):
# Stop the listener to ensure all messages are written
if _current_listener is not None:
_current_listener.stop()
# Give a moment for the listener to fully stop
await trio.sleep(0.05)
# Close all file handlers to release the file
for handler in _current_handlers:
if isinstance(handler, logging.FileHandler):
@ -203,12 +203,14 @@ async def test_default_log_file(clean_env):
with patch("libp2p.utils.paths.create_temp_file") as mock_create_temp:
# Mock the temp file creation to return a predictable path
mock_temp_file = Path(tempfile.gettempdir()) / "test_py-libp2p_20240101_120000.log"
mock_temp_file = (
Path(tempfile.gettempdir()) / "test_py-libp2p_20240101_120000.log"
)
mock_create_temp.return_value = mock_temp_file
# Remove the log file if it exists
mock_temp_file.unlink(missing_ok=True)
setup_logging()
# Wait for the listener to be ready
@ -223,10 +225,10 @@ async def test_default_log_file(clean_env):
# Stop the listener to ensure all messages are written
if _current_listener is not None:
_current_listener.stop()
# Give a moment for the listener to fully stop
await trio.sleep(0.05)
# Close all file handlers to release the file
for handler in _current_handlers:
if isinstance(handler, logging.FileHandler):

View File

@ -220,11 +220,11 @@ class TestCrossPlatformCompatibility:
def test_config_dir_platform_specific_windows(self, monkeypatch):
"""Test config directory respects Windows conventions."""
import platform
# Only run this test on Windows systems
if platform.system() != "Windows":
pytest.skip("This test only runs on Windows systems")
monkeypatch.setattr("os.name", "nt")
monkeypatch.setenv("APPDATA", "C:\\Users\\Test\\AppData\\Roaming")
config_dir = get_config_dir()