Remove pylint:disable

libp2p/kademlia/crawling.py

@@ -5,17 +5,15 @@ from .kad_peerinfo import KadPeerHeap, create_kad_peerinfo
 from .utils import gather_dict
 
 
-log = logging.getLogger(__name__)  # pylint: disable=invalid-name
+log = logging.getLogger(__name__)
 
 
-# pylint: disable=too-few-public-methods
 class SpiderCrawl:
     """
     Crawl the network and look for given 160-bit keys.
     """
 
     def __init__(self, protocol, node, peers, ksize, alpha):
-        # pylint: disable=too-many-arguments
         """
         Create a new C{SpiderCrawl}er.
 
@@ -72,7 +70,6 @@ class SpiderCrawl:
 
 class ValueSpiderCrawl(SpiderCrawl):
     def __init__(self, protocol, node, peers, ksize, alpha):
-        # pylint: disable=too-many-arguments
         SpiderCrawl.__init__(self, protocol, node, peers, ksize, alpha)
         # keep track of the single nearest node without value - per
         # section 2.3 so we can set the key there if found

libp2p/kademlia/kad_peerinfo.py

@@ -21,7 +21,6 @@ class KadPeerInfo(PeerInfo):
 
         self.addrs = peer_data.get_addrs() if peer_data else None
 
-        # pylint: disable=invalid-name
         self.ip = self.addrs[0].value_for_protocol(P_IP) if peer_data else None
         self.port = int(self.addrs[0].value_for_protocol(P_UDP)) if peer_data else None
 
@@ -143,7 +142,7 @@ def create_kad_peerinfo(node_id_bytes=None, sender_ip=None, sender_port=None):
     )
     peer_data = None
     if sender_ip and sender_port:
-        peer_data = PeerData()  # pylint: disable=no-value-for-parameter
+        peer_data = PeerData()
         addr = [
             Multiaddr(
                 "/" + P_IP + "/" + str(sender_ip) + "/" + P_UDP + "/" + str(sender_port)

libp2p/kademlia/network.py

@@ -12,10 +12,9 @@ from .kad_peerinfo import create_kad_peerinfo
 from .crawling import ValueSpiderCrawl
 from .crawling import NodeSpiderCrawl
 
-log = logging.getLogger(__name__)  # pylint: disable=invalid-name
+log = logging.getLogger(__name__)
 
 
-# pylint: disable=too-many-instance-attributes
 class KademliaServer:
     """
     High level view of a node instance.  This is the object that should be
@@ -260,4 +259,4 @@ def check_dht_value_type(value):
     placing in the dht.
     """
     typeset = [int, float, bool, str, bytes]
-    return type(value) in typeset  # pylint: disable=unidiomatic-typecheck
+    return type(value) in typeset

libp2p/kademlia/protocol.py

@@ -7,7 +7,7 @@ from .kad_peerinfo import create_kad_peerinfo
 from .routing import RoutingTable
 
 
-log = logging.getLogger(__name__)  # pylint: disable=invalid-name
+log = logging.getLogger(__name__)
 
 
 class KademliaProtocol(RPCProtocol):
@@ -37,7 +37,7 @@ class KademliaProtocol(RPCProtocol):
             ids.append(rid)
         return ids
 
-    def rpc_stun(self, sender):  # pylint: disable=no-self-use
+    def rpc_stun(self, sender):
         return sender
 
     def rpc_ping(self, sender, nodeid):
@@ -75,7 +75,6 @@ class KademliaProtocol(RPCProtocol):
         return {"value": value}
 
     def rpc_add_provider(self, sender, nodeid, key, provider_id):
-        # pylint: disable=unused-argument
         """
         rpc when receiving an add_provider call
         should validate received PeerInfo matches sender nodeid
@@ -91,7 +90,6 @@ class KademliaProtocol(RPCProtocol):
         return False
 
     def rpc_get_providers(self, sender, key):
-        # pylint: disable=unused-argument
         """
         rpc when receiving a get_providers call
         should look up key in data store and respond with records