Refactor P2PWebSocketConnection and WebsocketTransport constructors for improved readability. Clean up whitespace and enhance logging for connection management.

This commit is contained in:
yashksaini-coder
2025-09-12 03:11:43 +05:30
parent 0271a36316
commit 4fdfdae9fb
3 changed files with 27 additions and 21 deletions

View File

@ -13,12 +13,17 @@ class P2PWebSocketConnection(ReadWriteCloser):
"""
Wraps a WebSocketConnection to provide the raw stream interface
that libp2p protocols expect.
Implements production-ready buffer management and flow control
as recommended in the libp2p WebSocket specification.
"""
def __init__(self, ws_connection: Any, ws_context: Any = None, max_buffered_amount: int = 4 * 1024 * 1024) -> None:
def __init__(
self,
ws_connection: Any,
ws_context: Any = None,
max_buffered_amount: int = 4 * 1024 * 1024,
) -> None:
self._ws_connection = ws_connection
self._ws_context = ws_context
self._read_buffer = b""
@ -31,23 +36,24 @@ class P2PWebSocketConnection(ReadWriteCloser):
"""Write data with flow control and buffer management"""
if self._closed:
raise IOException("Connection is closed")
async with self._write_lock:
try:
logger.debug(f"WebSocket writing {len(data)} bytes")
# Check buffer amount for flow control
if hasattr(self._ws_connection, 'bufferedAmount'):
if hasattr(self._ws_connection, "bufferedAmount"):
buffered = self._ws_connection.bufferedAmount
if buffered > self._max_buffered_amount:
logger.warning(f"WebSocket buffer full: {buffered} bytes")
# In production, you might want to wait or implement backpressure
# In production, you might want to
# wait or implement backpressure
# For now, we'll continue but log the warning
# Send as a binary WebSocket message
await self._ws_connection.send_message(data)
logger.debug(f"WebSocket wrote {len(data)} bytes successfully")
except Exception as e:
logger.error(f"WebSocket write failed: {e}")
self._closed = True
@ -147,7 +153,7 @@ class P2PWebSocketConnection(ReadWriteCloser):
"""Close the WebSocket connection with proper cleanup"""
if self._closed:
return
self._closed = True
try:
# Close the WebSocket connection
@ -157,7 +163,7 @@ class P2PWebSocketConnection(ReadWriteCloser):
await self._ws_context.__aexit__(None, None, None)
except Exception as e:
logger.error(f"Error closing WebSocket connection: {e}")
def is_closed(self) -> bool:
"""Check if the connection is closed"""
return self._closed