varun-r-mallya/py-libp2p
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/py-libp2p.git synced 2026-02-09 22:50:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

PR feedbacks

Browse Source 
- Nits
- Add `SecurityUpgradeFailure` and handle `UpgradeFailure` in Swarm.
This commit is contained in:
mhchia
2019-08-20 16:42:34 +08:00
parent 2a1367b011
commit 5768daa9bf
6 changed files with 33 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
libp2p/security/simple/transport.py
View File

@ -6,6 +6,7 @@ from libp2p.peer.id import ID
from libp2p.security.base_transport import BaseSecureTransport
from libp2p.security.insecure.transport import InsecureSession
from libp2p.security.secure_conn_interface import ISecureConn
from libp2p.transport.exceptions import SecurityUpgradeFailure
class SimpleSecurityTransport(BaseSecureTransport):
@ -25,14 +26,14 @@ class SimpleSecurityTransport(BaseSecureTransport):
incoming = (await conn.read()).decode()
if incoming != self.key_phrase:
raise Exception(
raise SecurityUpgradeFailure(
"Key phrase differed between nodes. Expected " + self.key_phrase
)
session = InsecureSession(self, conn, ID(b""))
# TODO: Calls handshake to make them know the peer id each other, otherwise tests fail.
# However, it seems pretty weird that `SimpleSecurityTransport` sends peer id through
# `Insecure`.
# NOTE: Here we calls `run_handshake` for both sides to exchange their public keys and
# peer ids, otherwise tests fail. However, it seems pretty weird that
# `SimpleSecurityTransport` sends peer id through `Insecure`.
await session.run_handshake()
# NOTE: this is abusing the abstraction we have here
# but this code may be deprecated soon and this exists
@ -55,14 +56,14 @@ class SimpleSecurityTransport(BaseSecureTransport):
await asyncio.sleep(0)
if incoming != self.key_phrase:
raise Exception(
raise SecurityUpgradeFailure(
"Key phrase differed between nodes. Expected " + self.key_phrase
)
session = InsecureSession(self, conn, peer_id)
# TODO: Calls handshake to make them know the peer id each other, otherwise tests fail.
# However, it seems pretty weird that `SimpleSecurityTransport` sends peer id through
# `Insecure`.
# NOTE: Here we calls `run_handshake` for both sides to exchange their public keys and
# peer ids, otherwise tests fail. However, it seems pretty weird that
# `SimpleSecurityTransport` sends peer id through `Insecure`.
await session.run_handshake()
# NOTE: this is abusing the abstraction we have here
# but this code may be deprecated soon and this exists