varun-r-mallya/py-libp2p
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/py-libp2p.git synced 2026-02-12 16:10:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

reject dht-msgs upon receiving invalid records

Browse Source
This commit is contained in:
lla-dane
2025-08-15 16:11:27 +05:30
parent efc899e872
commit 57d1c9d807
5 changed files with 89 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
libp2p/kad_dht/provider_store.py
View File

@ -286,8 +286,13 @@ class ProviderStore:
if response.type == Message.MessageType.ADD_PROVIDER:
# Consume the sender's signed-peer-record if sent
_ = maybe_consume_signed_record(response, self.host)
result = True
if not maybe_consume_signed_record(response, self.host):
logger.error(
"Received an invalid-signed-record, ignoring the response"
)
result = False
else:
result = True
except Exception as e:
logger.warning(f"Error sending ADD_PROVIDER to {peer_id}: {e}")
@ -427,12 +432,24 @@ class ProviderStore:
return []
# Consume the sender's signed-peer-record if sent
_ = maybe_consume_signed_record(response, self.host)
if not maybe_consume_signed_record(response, self.host):
logger.error(
"Recieved an invalid-signed-record, ignoring the response"
)
return []
# Extract provider information
providers = []
for provider_proto in response.providerPeers:
try:
# Consume the provider's signed-peer-record if sent
if not maybe_consume_signed_record(provider_proto, self.host):
logger.error(
"Recieved an invalid-signed-record, "
"ignoring the response"
)
return []
# Create peer ID from bytes
provider_id = ID(provider_proto.id)
@ -447,9 +464,6 @@ class ProviderStore:
# Create PeerInfo and add to result
providers.append(PeerInfo(provider_id, addrs))
# Consume the provider's signed-peer-record if sent
_ = maybe_consume_signed_record(provider_proto, self.host)
except Exception as e:
logger.warning(f"Failed to parse provider info: {e}")