From 7df6424ff1b090f6a580aa3245236a5e0f9e5bbf Mon Sep 17 00:00:00 2001 From: zixuanzh Date: Wed, 21 Nov 2018 00:41:13 -0500 Subject: [PATCH] todo for close and reset --- stream_muxer/mplex/mplex_stream.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/stream_muxer/mplex/mplex_stream.py b/stream_muxer/mplex/mplex_stream.py index f310a34f..417ef647 100644 --- a/stream_muxer/mplex/mplex_stream.py +++ b/stream_muxer/mplex/mplex_stream.py @@ -55,7 +55,8 @@ class MplexStream(IMuxedStream): but allows writing in the other direction. :return: true if successful """ - #TODO error handling with timeout + # TODO error handling with timeout + # TODO understand better how mutexes are used from go repo await self.mplex_conn.send_message(self.get_flag("CLOSE"), None, self.stream_id) remote_lock = "" @@ -77,6 +78,8 @@ class MplexStream(IMuxedStream): tells this remote side to hang up :return: true if successful """ + # TODO understand better how mutexes are used here + # TODO understand the difference between close and reset async with self.stream_lock: if self.remote_closed and self.local_closed: return True