From ad87e50eb7e012d2cce3e37da6f3f108f322dd2f Mon Sep 17 00:00:00 2001 From: sukhman Date: Mon, 30 Jun 2025 10:12:02 +0530 Subject: [PATCH] move concurrency_limit to identify_push Signed-off-by: sukhman --- libp2p/identity/identify_push/identify_push.py | 3 ++- tests/core/identity/identify_push/test_identify_push.py | 7 +++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libp2p/identity/identify_push/identify_push.py b/libp2p/identity/identify_push/identify_push.py index 7a9c10a9..71656c27 100644 --- a/libp2p/identity/identify_push/identify_push.py +++ b/libp2p/identity/identify_push/identify_push.py @@ -40,7 +40,8 @@ logger = logging.getLogger(__name__) ID_PUSH = TProtocol("/ipfs/id/push/1.0.0") PROTOCOL_VERSION = "ipfs/0.1.0" AGENT_VERSION = get_agent_version() -LIMIT = trio.Semaphore(10) +CONCURRENCY_LIMIT = 10 +LIMIT = trio.Semaphore(CONCURRENCY_LIMIT) def identify_push_handler_for(host: IHost) -> StreamHandlerFn: diff --git a/tests/core/identity/identify_push/test_identify_push.py b/tests/core/identity/identify_push/test_identify_push.py index 1a617b1f..b0ffb677 100644 --- a/tests/core/identity/identify_push/test_identify_push.py +++ b/tests/core/identity/identify_push/test_identify_push.py @@ -20,6 +20,7 @@ from libp2p.identity.identify.pb.identify_pb2 import ( Identify, ) from libp2p.identity.identify_push.identify_push import ( + CONCURRENCY_LIMIT, ID_PUSH, _update_peerstore_from_identify, identify_push_handler_for, @@ -449,8 +450,6 @@ async def test_push_identify_to_peers_respects_concurrency_limit(): It mocks `push_identify_to_peer` to simulate delay using sleep, allowing the test to measure and assert actual concurrency behavior. """ - CONCURRENCY_LIMIT = 10 - LIMIT = trio.Semaphore(CONCURRENCY_LIMIT) state = { "concurrency_counter": 0, "max_observed": 0, @@ -458,7 +457,7 @@ async def test_push_identify_to_peers_respects_concurrency_limit(): lock = trio.Lock() async def mock_push_identify_to_peer( - host, peer_id, observed_multiaddr=None + host, peer_id, observed_multiaddr=None, limit=trio.Semaphore(CONCURRENCY_LIMIT) ) -> bool: """ Mock function to test concurrency by simulating an identify message. @@ -471,7 +470,7 @@ async def test_push_identify_to_peers_respects_concurrency_limit(): True if the push was successful, False otherwise. """ - async with LIMIT: + async with limit: async with lock: state["concurrency_counter"] += 1 if state["concurrency_counter"] > CONCURRENCY_LIMIT: