varun-r-mallya/py-libp2p
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/py-libp2p.git synced 2026-02-12 16:10:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #803 from acul71/fix/fix-592-32bytes_prefix_go_fixme_comment

Browse Source 
Remove FIXME about 32 bytes prefix in noise
This commit is contained in:
Manu Sheel Gupta
2025-08-08 12:51:44 +05:30
committed by GitHub
parent cb11f076c8 678b920992
commit b143c96abd
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libp2p/security/noise/io.py
View File

@ -41,7 +41,8 @@ class BaseNoiseMsgReadWriter(EncryptedMsgReadWriter):
read_writer: NoisePacketReadWriter read_writer: NoisePacketReadWriter
noise_state: NoiseState noise_state: NoiseState
# FIXME: This prefix is added in msg#3 in Go. Check whether it's a desired behavior. # NOTE: This prefix is added in msg#3 in Go.
# Support in py-libp2p is available but not used
prefix: bytes = b"\x00" * 32 prefix: bytes = b"\x00" * 32
def __init__(self, conn: IRawConnection, noise_state: NoiseState) -> None: def __init__(self, conn: IRawConnection, noise_state: NoiseState) -> None:

1
newsfragments/592.internal.rst Normal file
View File

@ -0,0 +1 @@
remove FIXME comment since it's obsolete and 32-byte prefix support is there but not enabled by default