From ba0fb8a833ffb736779af1d7a40a885128fd7a93 Mon Sep 17 00:00:00 2001 From: mhchia Date: Wed, 5 Feb 2020 20:36:42 +0800 Subject: [PATCH] Fix: use `pass` over `...`(Ellipse) Use `...`(Ellipse) only in abstract methods. --- libp2p/network/network_interface.py | 2 +- libp2p/pubsub/exceptions.py | 4 ++-- libp2p/pubsub/pubsub_notifee.py | 4 ++-- tests/transport/test_tcp.py | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libp2p/network/network_interface.py b/libp2p/network/network_interface.py index c759a411..70fb7295 100644 --- a/libp2p/network/network_interface.py +++ b/libp2p/network/network_interface.py @@ -74,4 +74,4 @@ class INetwork(ABC): class INetworkService(INetwork, ServiceAPI): - ... + pass diff --git a/libp2p/pubsub/exceptions.py b/libp2p/pubsub/exceptions.py index a47446de..55afde04 100644 --- a/libp2p/pubsub/exceptions.py +++ b/libp2p/pubsub/exceptions.py @@ -2,8 +2,8 @@ from libp2p.exceptions import BaseLibp2pError class PubsubRouterError(BaseLibp2pError): - ... + pass class NoPubsubAttached(PubsubRouterError): - ... + pass diff --git a/libp2p/pubsub/pubsub_notifee.py b/libp2p/pubsub/pubsub_notifee.py index b32c1450..cf728843 100644 --- a/libp2p/pubsub/pubsub_notifee.py +++ b/libp2p/pubsub/pubsub_notifee.py @@ -50,7 +50,7 @@ class PubsubNotifee(INotifee): await self.initiator_peers_queue.send(conn.muxed_conn.peer_id) except trio.BrokenResourceError: # The receive channel is closed by Pubsub. We should do nothing here. - ... + pass async def disconnected(self, network: INetwork, conn: INetConn) -> None: """ @@ -64,7 +64,7 @@ class PubsubNotifee(INotifee): await self.dead_peers_queue.send(conn.muxed_conn.peer_id) except trio.BrokenResourceError: # The receive channel is closed by Pubsub. We should do nothing here. - ... + pass async def listen(self, network: INetwork, multiaddr: Multiaddr) -> None: await trio.hazmat.checkpoint() diff --git a/tests/transport/test_tcp.py b/tests/transport/test_tcp.py index aca499ab..130b3cc4 100644 --- a/tests/transport/test_tcp.py +++ b/tests/transport/test_tcp.py @@ -13,7 +13,7 @@ async def test_tcp_listener(nursery): transport = TCP() async def handler(tcp_stream): - ... + pass listener = transport.create_listener(handler) assert len(listener.get_addrs()) == 0