Apply PR feedback: fix type hints

This commit is contained in:
NIC619
2019-07-30 15:31:02 +08:00
parent 2d4e23cfe2
commit e53727d301
15 changed files with 65 additions and 52 deletions

View File

@ -39,10 +39,10 @@ class PeerData(IPeerData):
def clear_addrs(self) -> None:
self.addrs = []
def put_metadata(self, key: Any, val: Any) -> None:
def put_metadata(self, key: str, val: Any) -> None:
self.metadata[key] = val
def get_metadata(self, key: Any) -> Any:
def get_metadata(self, key: str) -> Any:
if key in self.metadata:
return self.metadata[key]
raise PeerDataError("key not found")

View File

@ -7,6 +7,8 @@ from typing import (
from multiaddr import Multiaddr
from .peermetadata_interface import IPeerMetadata
class IPeerData(ABC):
@ -47,7 +49,7 @@ class IPeerData(ABC):
"""
@abstractmethod
def put_metadata(self, key: Any, val: Any) -> None:
def put_metadata(self, key: str, val: Any) -> None:
"""
:param key: key in KV pair
:param val: val to associate with key
@ -55,7 +57,7 @@ class IPeerData(ABC):
"""
@abstractmethod
def get_metadata(self, key: Any) -> Any:
def get_metadata(self, key: str) -> IPeerMetadata:
"""
:param key: key in KV pair
:return: val for key

View File

@ -14,7 +14,7 @@ class IPeerMetadata(ABC):
pass
@abstractmethod
def get(self, peer_id: ID, key: Any) -> Any:
def get(self, peer_id: ID, key: str) -> Any:
"""
:param peer_id: peer ID to lookup key for
:param key: key to look up
@ -23,7 +23,7 @@ class IPeerMetadata(ABC):
"""
@abstractmethod
def put(self, peer_id: ID, key: Any, val: Any) -> None:
def put(self, peer_id: ID, key: str, val: Any) -> None:
"""
:param peer_id: peer ID to lookup key for
:param key: key to associate with peer

View File

@ -58,13 +58,13 @@ class PeerStore(IPeerStore):
def peer_ids(self) -> List[ID]:
return list(self.peer_map.keys())
def get(self, peer_id: ID, key: Any) -> Any:
def get(self, peer_id: ID, key: str) -> Any:
if peer_id in self.peer_map:
val = self.peer_map[peer_id].get_metadata(key)
return val
raise PeerStoreError("peer ID not found")
def put(self, peer_id: ID, key: Any, val: Any) -> None:
def put(self, peer_id: ID, key: str, val: Any) -> None:
# <<?>>
# This can output an error, not sure what the possible errors are
peer = self.__create_or_get_peer(peer_id)