From 26d0ed2d81453684111c0591fa43bafe4ae4461c Mon Sep 17 00:00:00 2001 From: acul71 <34693171+acul71@users.noreply.github.com> Date: Sat, 9 Aug 2025 23:25:23 +0000 Subject: [PATCH] remove deprecated IK pattern TODO --- libp2p/security/noise/transport.py | 5 ----- newsfragments/816.internal.rst | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) create mode 100644 newsfragments/816.internal.rst diff --git a/libp2p/security/noise/transport.py b/libp2p/security/noise/transport.py index 8fdd6b6e..b26e0644 100644 --- a/libp2p/security/noise/transport.py +++ b/libp2p/security/noise/transport.py @@ -29,11 +29,6 @@ class Transport(ISecureTransport): early_data: bytes | None with_noise_pipes: bool - # NOTE: Implementations that support Noise Pipes must decide whether to use - # an XX or IK handshake based on whether they possess a cached static - # Noise key for the remote peer. - # TODO: A storage of seen noise static keys for pattern IK? - def __init__( self, libp2p_keypair: KeyPair, diff --git a/newsfragments/816.internal.rst b/newsfragments/816.internal.rst new file mode 100644 index 00000000..ade49df8 --- /dev/null +++ b/newsfragments/816.internal.rst @@ -0,0 +1 @@ +The TODO IK patterns in Noise has been deprecated in specs: https://github.com/libp2p/specs/tree/master/noise#handshake-pattern