Commit Graph

1969 Commits

Author SHA1 Message Date
f20b78c93f Replace pylint with flake8
This change removes the use of pylint and implements similar
code style checks. This is complementary with black code formatter.
2019-08-04 00:06:34 +08:00
4fef80595c Skip pb files in linters
In isort, black, and flake8, respectively.

Add `format` in Makefile

Run top level packages only

With `setup.py`, to avoid running other unrelated directories.

Refactor
2019-08-03 23:34:56 +08:00
c8005c8113 Run isort in repo 2019-08-03 17:50:14 +08:00
a92d933ed2 Add isort to CI check 2019-08-03 17:50:14 +08:00
d78e6dbf04 Add black-compatible isort config 2019-08-03 17:50:14 +08:00
201850397a Add isort as a lint dep 2019-08-03 17:50:14 +08:00
21e013e753 Merge pull request #214 from ralexstokes/remove-third-party-key-in-id
Refactor ID to not use third-party type for cryptographic keys
2019-08-02 22:50:53 -07:00
6090d2ca3b Clean up old comments, print stmts, formatting, etc. 2019-08-02 21:58:31 -07:00
bd8d45fbc1 Refactor ID to not use third-party type for cryptographic keys
Remove `ID.from_privkey` which would require specific knowledge per cryptosystem
2019-08-02 21:51:16 -07:00
cff5fe0d5f Add pytest config 2019-08-02 15:58:39 -07:00
28e1a03dc4 remove empty yamux impl 2019-08-02 15:03:59 -07:00
d47cddee24 Clean up extraneous files in tests 2019-08-02 14:54:40 -07:00
224b54ad93 Add basic flake8 config 2019-08-02 14:38:03 -07:00
2dfd7794b6 add note about protoc version and add Make command to generate protobuf files 2019-08-02 12:20:48 -07:00
e55d9f2e60 restore generated protobuf files 2019-08-02 12:09:27 -07:00
88a3a3159e Add clarifying comment about InsecureTransport 2019-08-02 12:07:35 -07:00
b2367e35d8 Merge pull request #208 from ralexstokes/disable-mypy-ci
disable mypy check during CI temporarily and move `black --check` to Makefile
2019-08-02 12:01:47 -07:00
7b7c8ad30d run black over dangling files 2019-08-02 11:47:08 -07:00
da9d5cadec Disables mypy in CI
Also moves linting to Makefile to take advantage of globbing.
2019-08-02 11:46:43 -07:00
612330d318 Merge pull request #205 from mhchia/fix/remove-pylint-leftover
Remove pylint related lines and files
2019-08-02 10:50:44 -07:00
c8d175b373 Add a localhost option and fix the printed example to run another peer 2019-08-02 10:22:15 -07:00
430b4e2f89 Bail as soon as we know there is a port error 2019-08-02 10:21:41 -07:00
2e94fcf56c Remove pylint:disable 2019-08-02 23:26:06 +08:00
06a9511ab4 Remove .pylintrc 2019-08-02 23:20:30 +08:00
7a0fa7dd37 Merge pull request #196 from NIC619/fix_peer_id
Refactor `peer.ID` class and only takes in `bytes` type argument
2019-08-02 18:03:56 +08:00
568454534f Remove unused ID type conversions 2019-08-02 16:48:38 +08:00
ee290b2ac2 Fix missing asterisk 2019-08-02 16:48:32 +08:00
3a4b592a5a Fix missing asterisk 2019-08-02 15:06:39 +08:00
38423cc2a4 Merge pull request #200 from ChihChengLiang/add-typing-security
Add typing to security module
2019-08-02 14:57:24 +08:00
0173b5e0d9 Add ID.to_base58() and comparison against str type 2019-08-02 14:46:01 +08:00
924e965537 Change argument name of Network.listen and blakc format 2019-08-02 14:45:59 +08:00
cd684aad9e Update peer_id to type peer.ID in pubsub folder 2019-08-02 14:45:23 +08:00
9562cb2a46 Rename:
`KadPeerInfo.peer_id` to `KadPeerInfo.peer_id_bytes`
2019-08-02 14:43:01 +08:00
f00e80bc25 Fix wrong peer id type used in KadPeerInfo 2019-08-02 14:42:10 +08:00
b928bdb356 Convert from base58/pubkey/privkey to class method 2019-08-02 14:42:10 +08:00
80481252ca Refactor ID to take in type bytes only 2019-08-02 14:42:10 +08:00
10a8347c6a PR feedback 2019-08-02 14:12:59 +08:00
f6e456c96e Merge pull request #198 from mhchia/fix/clean-up-tests-with-fixture
Use factories and fixtures in pubsub tests
2019-08-01 22:08:03 +08:00
716c60ca6d Reflect PR feedback
- Remove leftover `int` in `GossipsubParams`
- Remove default fields in tests
2019-08-01 21:38:14 +08:00
e731f77f2d minor 2019-08-01 19:13:43 +08:00
a86f010c95 add typing to security 2019-08-01 19:12:11 +08:00
030abcc959 add vscode 2019-08-01 17:55:15 +08:00
33d233f5df Add missing comma 2019-08-01 13:31:02 +08:00
4eb846be7c Remove the assertions for connect
Because it fails in `test_security_multistream.py` and this check is
indeed not necessary inside `connect`.(Should probably be outside the
function.)
2019-08-01 13:30:09 +08:00
c72dfe1dd3 Use factories and fixtures in pubsub tests
Done
- Add factories using factory-boy
- Modify fixtures and tests to use factories
- Modify tests to use fixtures and factories
- Clean up
2019-08-01 13:30:08 +08:00
9181cf95f0 Merge pull request #199 from ralexstokes/add-black-to-repo
Add `black` to repo
2019-08-01 10:53:44 +08:00
51cc710dc0 remove pylint 2019-07-31 15:14:56 -07:00
0ae9840928 Run black over repo 2019-07-31 15:00:12 -07:00
a2133d8c7c Add black check to CI 2019-07-31 14:59:47 -07:00
936369aa5e Add black as a lint dependency 2019-07-31 14:53:28 -07:00