Commit Graph

56 Commits

Author SHA1 Message Date
5b32bfdd3f Add call to wait_closed method of asyncio.StreamWriter 2019-08-24 22:06:24 +02:00
9c5fb4fa5a Encapsulate concept of a "stream id" to a "muxed" connection 2019-08-24 21:50:07 +02:00
73495038e1 remove simple security 2019-08-24 21:39:25 +02:00
1790e48c99 Remove deprecated file 2019-08-24 21:36:30 +02:00
c1eacf221f PR feedback
- Check if the received peer id matches the one we initialize the
session with.
- Move the check inside `run_handshake`
2019-08-22 22:53:49 +08:00
7c630df610 Update libp2p/security/insecure/transport.py
Co-Authored-By: NIC Lin <twedusuck@gmail.com>
2019-08-22 22:53:49 +08:00
16a4fd33c1 PR feedbacks
- Move exceptions to exceptions.py
- Raise `UpgradeFailure` in upgrader
- Refine the try/catch for upgraders in swarm
2019-08-22 22:53:49 +08:00
3e04480d62 Raise HandshakeFailure in transport
Change the exception handling flow.
Raise `SecurityUpgradeFailure` in security_multistream.
2019-08-22 22:53:48 +08:00
80452d9589 Fix make_exchange_message to use the new API 2019-08-22 22:53:48 +08:00
921bfb65cc Verify the remote pubkey and peer_id
- Add `from_bytes` in RSAPublicKey and Secp256k1PublicKey
- Add `pubkey_from_protobuf` to parse pubkey from protobuf
- Verify key and peer_id in `InsecureSession.run_handshake`
2019-08-22 22:53:48 +08:00
ef476e555b Use RawConnection.read
Instead of accessing its reader and writer directly.

TODO: considering add `ReaderWriterCloser` interface and let connection
and stream inherit from it.
2019-08-22 22:53:48 +08:00
0b466ddc86 Add lock to RawConnection
To avoid `self.writer.drain()` is called in parallel.
Reference: https://bugs.python.org/issue29930
2019-08-22 22:53:47 +08:00
5768daa9bf PR feedbacks
- Nits
- Add `SecurityUpgradeFailure` and handle `UpgradeFailure` in Swarm.
2019-08-22 22:53:47 +08:00
2a1367b011 Apply suggestions from code review
Co-Authored-By: NIC Lin <twedusuck@gmail.com>
2019-08-22 22:53:47 +08:00
de8d356955 Fix tests failure due to lack of peer id
Fix it through doing plaintext handshake.
2019-08-22 22:53:47 +08:00
bb7d37fd4f Fix msg encoding
- Change varint-prefix encode to fixedint-prefix(4 bytes) encode.
2019-08-22 22:53:46 +08:00
22b1a5395d A working plaintext 2.0 without validation 2019-08-22 22:53:46 +08:00
a0923d202a Move varint and delim read/write to toplevel
To `libp2p.utils`.
2019-08-22 22:53:46 +08:00
59b373b48a Add plaintext.proto
Update Makefile to handle the import in `plaintext.proto`.
Import path is modified to be relative to the project root.
And we run `protoc` from where `Makefile` locates, i.e. the project
root.

Reference:
- plaintext.proto: 62b2c6c482/sec/insecure/pb/plaintext.proto
2019-08-22 22:53:46 +08:00
2752e7a04b Ignore mypy error here 2019-08-22 15:58:38 +08:00
dbd4ed44dd Fix the issue when importing from other package 2019-08-22 15:36:17 +08:00
550c23f9f9 PR feedback
- Use the order in `MuxerMultistream` as the precedence in multiselect
2019-08-21 11:43:25 +08:00
8596f7390f PR feedback: set protocol_id to constants 2019-08-21 11:43:24 +08:00
4358a4bc89 Negotiate multiselect version for Muxer
`MuxerMultistream` is introduced to negotiate `Multiselect` version
before negotiating Multiplexer's version. This is required by
multistream 1.x
2019-08-21 11:43:24 +08:00
5d611801c7 Fix isort 2019-08-18 19:51:04 +08:00
86d4ce1da8 Add delim_encode and delim_read
- Add `StreamCommunicator` and `RawConnectionCommunicator`, read/write
messages with delim codec, with `IMuxedStream` and `IRawConnection`
respectively.
- Use it in `Multiselect` and `MultiselectClient`.
2019-08-18 19:51:04 +08:00
7535a02da7 Clean up key gen 2019-08-15 19:24:30 -07:00
2e3ffb9d53 Use types for {Private,Public}Key and address other missing type hints 2019-08-15 16:33:34 -07:00
e7d2681fc0 Move base implementations into BaseSession 2019-08-15 16:33:34 -07:00
9e18d7561d Supply local priv and pub key when upgrading to a secure transport 2019-08-15 16:33:34 -07:00
7942b7eaa7 Expose writer 2019-08-15 16:33:34 -07:00
0ebc8ffb21 Wire some missing properties up 2019-08-15 16:33:34 -07:00
879cbf1abd Add an "insecure session" that satisfies the ISecureConn interface 2019-08-15 16:33:33 -07:00
1e5357a1e1 Update the ISecureConn interface following the reference and simplify accordingly 2019-08-15 16:33:33 -07:00
ab7653526f Code cleanup / formatting 2019-08-15 16:33:33 -07:00
b98025c379 Move security transports into their respective sub-packages 2019-08-15 16:33:33 -07:00
d50e1b6872 Use direct types over indirect types 2019-08-15 16:33:32 -07:00
3debd2c808 Run black and isort w/ the new config 2019-08-13 14:36:42 -07:00
9851ee01fb sort import 2019-08-08 16:09:02 +08:00
c536aa3e07 flake8 2019-08-08 16:09:02 +08:00
5903012e0e add typing to protocol_muxer 2019-08-08 16:09:02 +08:00
7477b29508 run black w/ extended line length 2019-08-04 12:37:41 +08:00
0a5b4a88ca Fix flake8 for the existing code 2019-08-04 00:18:30 +08:00
c8005c8113 Run isort in repo 2019-08-03 17:50:14 +08:00
88a3a3159e Add clarifying comment about InsecureTransport 2019-08-02 12:07:35 -07:00
2e94fcf56c Remove pylint:disable 2019-08-02 23:26:06 +08:00
10a8347c6a PR feedback 2019-08-02 14:12:59 +08:00
e731f77f2d minor 2019-08-01 19:13:43 +08:00
a86f010c95 add typing to security 2019-08-01 19:12:11 +08:00
0ae9840928 Run black over repo 2019-07-31 15:00:12 -07:00