varun-r-mallya/python-bpf
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/Python-BPF.git synced 2025-12-31 21:06:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Janitorial: Remove useless comments

Browse Source
This commit is contained in:
Pragyansh Chaturvedi
2025-11-23 06:29:44 +05:30
committed by varun-r-mallya
parent 84edddb685
commit 4ea02745b3
2 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pythonbpf/expr/ir_ops.py
View File

@ -37,22 +37,18 @@ def _null_checked_operation(func, builder, ptr, operation, result_type, name_pre
not_null_block = func.append_basic_block(name=f"{name_prefix}_not_null") not_null_block = func.append_basic_block(name=f"{name_prefix}_not_null")
merge_block = func.append_basic_block(name=f"{name_prefix}_merge") merge_block = func.append_basic_block(name=f"{name_prefix}_merge")
# Null check
null_ptr = ir.Constant(ptr.type, None) null_ptr = ir.Constant(ptr.type, None)
is_not_null = builder.icmp_signed("!=", ptr, null_ptr) is_not_null = builder.icmp_signed("!=", ptr, null_ptr)
builder.cbranch(is_not_null, not_null_block, merge_block) builder.cbranch(is_not_null, not_null_block, merge_block)
# Not-null path: execute operation
builder.position_at_end(not_null_block) builder.position_at_end(not_null_block)
result = operation(builder, ptr) result = operation(builder, ptr)
not_null_after = builder.block not_null_after = builder.block
builder.branch(merge_block) builder.branch(merge_block)
# Merge with PHI
builder.position_at_end(merge_block) builder.position_at_end(merge_block)
phi = builder.phi(result_type, name=f"{name_prefix}_result") phi = builder.phi(result_type, name=f"{name_prefix}_result")
# Null fallback value
if isinstance(result_type, ir.IntType): if isinstance(result_type, ir.IntType):
null_val = ir.Constant(result_type, 0) null_val = ir.Constant(result_type, 0)
elif isinstance(result_type, ir.PointerType): elif isinstance(result_type, ir.PointerType):
@ -72,7 +68,6 @@ def access_struct_field(
""" """
Access a struct field - automatically returns value or pointer based on field type. Access a struct field - automatically returns value or pointer based on field type.
""" """
# Get struct metadata
metadata = ( metadata = (
structs_sym_tab.get(var_metadata) structs_sym_tab.get(var_metadata)
if isinstance(var_metadata, str) if isinstance(var_metadata, str)
@ -89,10 +84,8 @@ def access_struct_field(
# Get struct pointer # Get struct pointer
struct_ptr = builder.load(var_ptr) if is_ptr_to_struct else var_ptr struct_ptr = builder.load(var_ptr) if is_ptr_to_struct else var_ptr
# Decide: load value or return pointer?
should_load = not isinstance(field_type, ir.ArrayType) should_load = not isinstance(field_type, ir.ArrayType)
# Define the field access operation
def field_access_op(builder, ptr): def field_access_op(builder, ptr):
typed_ptr = builder.bitcast(ptr, metadata.ir_type.as_pointer()) typed_ptr = builder.bitcast(ptr, metadata.ir_type.as_pointer())
field_ptr = metadata.gep(builder, typed_ptr, field_name) field_ptr = metadata.gep(builder, typed_ptr, field_name)
@ -118,7 +111,6 @@ def access_struct_field(
) )
return result, field_type return result, field_type
# No null check needed
field_ptr = metadata.gep(builder, struct_ptr, field_name) field_ptr = metadata.gep(builder, struct_ptr, field_name)
result = builder.load(field_ptr) if should_load else field_ptr result = builder.load(field_ptr) if should_load else field_ptr
return result, field_type return result, field_type

1
pythonbpf/helper/helper_utils.py
View File

@ -304,7 +304,6 @@ def get_char_array_ptr_and_size(
logger.warning("Field is not a char array") logger.warning("Field is not a char array")
return None, 0 return None, 0
# Get field pointer (automatically handles null checks!)
field_ptr, _ = access_struct_field( field_ptr, _ = access_struct_field(
builder, builder,
struct_ptr, struct_ptr,