From af44bd063cb90adf2d80f6d42fd8514616d33a7e Mon Sep 17 00:00:00 2001 From: Pragyansh Chaturvedi Date: Sat, 4 Oct 2025 02:13:46 +0530 Subject: [PATCH] Add explanation for direct_assign.py failing test --- tests/failing_tests/direct_assign.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/failing_tests/direct_assign.py b/tests/failing_tests/direct_assign.py index 18ff266..5d2454e 100644 --- a/tests/failing_tests/direct_assign.py +++ b/tests/failing_tests/direct_assign.py @@ -4,6 +4,18 @@ from pythonbpf.maps import HashMap from ctypes import c_void_p, c_int64 +# NOTE: I have decided to not fix this example for now. +# The issue is in line 31, where we are passing an expression. +# The update helper expects a pointer type. But the problem is +# that we must allocate the space for said pointer in the first +# basic block. As that usage is in a different basic block, we +# are unable to cast the expression to a pointer type. (as we never +# allocated space for it). +# Shall we change our space allocation logic? That allows users to +# spam the same helper with the same args, and still run out of +# stack space. So we consider this usage invalid for now. +# Might fix it later. + @bpf @map