varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-12 16:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof-profile: avoid splitting string into lines

Browse Source 
We will always have either \n or \0 at the end, so we can just sscanf this
without needing to split strings.

The sscanf() is still our top offender though, and so we should probably
look for other ways to parse this string than sscanf().
This commit is contained in:
Christian Hergert
2023-06-05 15:27:16 -07:00
parent 06a2a1a211
commit 0c6fcea79b
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/libsysprof-profile/sysprof-linux-instrument.c
View File

@ -26,6 +26,8 @@
#include "sysprof-podman-private.h" #include "sysprof-podman-private.h"
#include "sysprof-recording-private.h" #include "sysprof-recording-private.h"
#include "line-reader-private.h"
struct _SysprofLinuxInstrument struct _SysprofLinuxInstrument
{ {
SysprofInstrument parent_instance; SysprofInstrument parent_instance;
@ -53,26 +55,28 @@ add_mmaps (SysprofRecording *recording,
gboolean ignore_inode) gboolean ignore_inode)
{ {
SysprofCaptureWriter *writer; SysprofCaptureWriter *writer;
g_auto(GStrv) lines = NULL; LineReader reader;
const char *line;
gsize line_len;
g_assert (SYSPROF_IS_RECORDING (recording)); g_assert (SYSPROF_IS_RECORDING (recording));
g_assert (mapsstr != NULL); g_assert (mapsstr != NULL);
g_assert (pid > 0); g_assert (pid > 0);
writer = _sysprof_recording_writer (recording); writer = _sysprof_recording_writer (recording);
lines = g_strsplit (mapsstr, "\n", 0);
for (guint i = 0; lines[i] != NULL; i++) line_reader_init (&reader, (char *)mapsstr, -1);
while ((line = line_reader_next (&reader, &line_len)))
{ {
char file[512]; char file[512];
gulong start; gulong start;
gulong end; gulong end;
gulong offset; gulong offset;
gulong inode; gulong inode;
int r;
gboolean is_vdso; gboolean is_vdso;
int r;
r = sscanf (lines[i], r = sscanf (line,
"%lx-%lx %*15s %lx %*x:%*x %lu %511[^\n]", "%lx-%lx %*15s %lx %*x:%*x %lu %511[^\n]",
&start, &end, &offset, &inode, file); &start, &end, &offset, &inode, file);
file [sizeof file - 1] = '\0'; file [sizeof file - 1] = '\0';