varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-12 08:00:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

sysprof: remove metadata dialog

Browse Source 
This is a section now, so we can drop this dialog.
This commit is contained in:
Christian Hergert
2023-07-10 09:36:01 -07:00
parent d0da970e86
commit 1ee9719f5a
7 changed files with 0 additions and 299 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/sysprof/meson.build
View File

@ -5,7 +5,6 @@ sysprof_sources = [
'sysprof-greeter.c', 'sysprof-greeter.c',
'sysprof-logs-section.c', 'sysprof-logs-section.c',
'sysprof-marks-section.c', 'sysprof-marks-section.c',
'sysprof-metadata-dialog.c',
'sysprof-metadata-section.c', 'sysprof-metadata-section.c',
'sysprof-recording-pad.c', 'sysprof-recording-pad.c',
'sysprof-samples-section.c', 'sysprof-samples-section.c',

129
src/sysprof/sysprof-metadata-dialog.c
View File

@ -1,129 +0,0 @@
/* sysprof-metadata-dialog.c
*
* Copyright 2023 Christian Hergert <chergert@redhat.com>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* SPDX-License-Identifier: GPL-3.0-or-later
*/
#include "config.h"
#include "sysprof-metadata-dialog.h"
struct _SysprofMetadataDialog
{
AdwWindow parent_instance;
SysprofDocument *document;
};
enum {
PROP_0,
PROP_DOCUMENT,
N_PROPS
};
G_DEFINE_FINAL_TYPE (SysprofMetadataDialog, sysprof_metadata_dialog, ADW_TYPE_WINDOW)
static GParamSpec *properties [N_PROPS];
static void
sysprof_metadata_dialog_dispose (GObject *object)
{
SysprofMetadataDialog *self = (SysprofMetadataDialog *)object;
gtk_widget_dispose_template (GTK_WIDGET (self), SYSPROF_TYPE_METADATA_DIALOG);
g_clear_object (&self->document);
G_OBJECT_CLASS (sysprof_metadata_dialog_parent_class)->dispose (object);
}
static void
sysprof_metadata_dialog_get_property (GObject *object,
guint prop_id,
GValue *value,
GParamSpec *pspec)
{
SysprofMetadataDialog *self = SYSPROF_METADATA_DIALOG (object);
switch (prop_id)
{
case PROP_DOCUMENT:
g_value_set_object (value, self->document);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
}
}
static void
sysprof_metadata_dialog_set_property (GObject *object,
guint prop_id,
const GValue *value,
GParamSpec *pspec)
{
SysprofMetadataDialog *self = SYSPROF_METADATA_DIALOG (object);
switch (prop_id)
{
case PROP_DOCUMENT:
self->document = g_value_dup_object (value);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
}
}
static void
sysprof_metadata_dialog_class_init (SysprofMetadataDialogClass *klass)
{
GObjectClass *object_class = G_OBJECT_CLASS (klass);
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (klass);
object_class->dispose = sysprof_metadata_dialog_dispose;
object_class->get_property = sysprof_metadata_dialog_get_property;
object_class->set_property = sysprof_metadata_dialog_set_property;
properties[PROP_DOCUMENT] =
g_param_spec_object ("document", NULL, NULL,
SYSPROF_TYPE_DOCUMENT,
(G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS));
g_object_class_install_properties (object_class, N_PROPS, properties);
gtk_widget_class_set_template_from_resource (widget_class, "/org/gnome/sysprof/sysprof-metadata-dialog.ui");
g_type_ensure (SYSPROF_TYPE_DOCUMENT_METADATA);
}
static void
sysprof_metadata_dialog_init (SysprofMetadataDialog *self)
{
gtk_widget_init_template (GTK_WIDGET (self));
}
GtkWidget *
sysprof_metadata_dialog_new (SysprofDocument *document)
{
g_return_val_if_fail (SYSPROF_IS_DOCUMENT (document), NULL);
return g_object_new (SYSPROF_TYPE_METADATA_DIALOG,
"document", document,
NULL);
}

36
src/sysprof/sysprof-metadata-dialog.h
View File

@ -1,36 +0,0 @@
/* sysprof-metadata-dialog.h
*
* Copyright 2023 Christian Hergert <chergert@redhat.com>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* SPDX-License-Identifier: GPL-3.0-or-later
*/
#pragma once
#include <adwaita.h>
#include <sysprof-analyze.h>
G_BEGIN_DECLS
#define SYSPROF_TYPE_METADATA_DIALOG (sysprof_metadata_dialog_get_type())
G_DECLARE_FINAL_TYPE (SysprofMetadataDialog, sysprof_metadata_dialog, SYSPROF, METADATA_DIALOG, AdwWindow)
GtkWidget *sysprof_metadata_dialog_new (SysprofDocument *document);
G_END_DECLS

108
src/sysprof/sysprof-metadata-dialog.ui
View File

@ -1,108 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
<interface>
<template class="SysprofMetadataDialog" parent="AdwWindow">
<property name="default-width">600</property>
<property name="default-height">400</property>
<child>
<object class="AdwToolbarView">
<property name="top-bar-style">raised</property>
<child type="top">
<object class="AdwHeaderBar">
<property name="title-widget">
<object class="AdwWindowTitle">
<property name="title" translatable="yes">Metadata</property>
</object>
</property>
</object>
</child>
<property name="content">
<object class="GtkScrolledWindow">
<child>
<object class="GtkColumnView">
<property name="model">
<object class="GtkNoSelection">
<binding name="model">
<lookup name="metadata" type="SysprofDocument">
<lookup name="document">SysprofMetadataDialog</lookup>
</lookup>
</binding>
</object>
</property>
<child>
<object class="GtkColumnViewColumn">
<property name="title" translatable="yes">Key</property>
<property name="sorter">
<object class="GtkStringSorter">
<property name="expression">
<lookup name="id" type="SysprofDocumentMetadata"/>
</property>
</object>
</property>
<property name="factory">
<object class="GtkBuilderListItemFactory">
<property name="bytes"><![CDATA[
<?xml version="1.0" encoding="UTF-8"?>
<interface>
<template class="GtkListItem">
<property name="child">
<object class="GtkLabel">
<property name="xalign">0</property>
<binding name="label">
<lookup name="id" type="SysprofDocumentMetadata">
<lookup name="item">GtkListItem</lookup>
</lookup>
</binding>
</object>
</property>
</template>
</interface>
]]>
</property>
</object>
</property>
</object>
</child>
<child>
<object class="GtkColumnViewColumn">
<property name="title" translatable="yes">Value</property>
<property name="expand">true</property>
<property name="sorter">
<object class="GtkStringSorter">
<property name="expression">
<lookup name="value" type="SysprofDocumentMetadata"/>
</property>
</object>
</property>
<property name="factory">
<object class="GtkBuilderListItemFactory">
<property name="bytes"><![CDATA[
<?xml version="1.0" encoding="UTF-8"?>
<interface>
<template class="GtkListItem">
<property name="child">
<object class="GtkLabel">
<property name="xalign">0</property>
<binding name="label">
<lookup name="value" type="SysprofDocumentMetadata">
<lookup name="item">GtkListItem</lookup>
</lookup>
</binding>
</object>
</property>
</template>
</interface>
]]>
</property>
</object>
</property>
</object>
</child>
</object>
</child>
</object>
</property>
</object>
</child>
</template>
</interface>

18
src/sysprof/sysprof-window.c
View File

@ -28,7 +28,6 @@
#include "sysprof-greeter.h" #include "sysprof-greeter.h"
#include "sysprof-logs-section.h" #include "sysprof-logs-section.h"
#include "sysprof-marks-section.h" #include "sysprof-marks-section.h"
#include "sysprof-metadata-dialog.h"
#include "sysprof-metadata-section.h" #include "sysprof-metadata-section.h"
#include "sysprof-samples-section.h" #include "sysprof-samples-section.h"
#include "sysprof-sidebar.h" #include "sysprof-sidebar.h"
@ -69,22 +68,6 @@ sysprof_window_open_capture_action (GtkWidget *widget,
gtk_window_present (GTK_WINDOW (greeter)); gtk_window_present (GTK_WINDOW (greeter));
} }
static void
sysprof_window_show_metadata_action (GtkWidget *widget,
const char *action_name,
GVariant *param)
{
SysprofWindow *self = (SysprofWindow *)widget;
GtkWidget *dialog;
g_assert (SYSPROF_IS_WINDOW (self));
g_assert (SYSPROF_IS_DOCUMENT (self->document));
dialog = sysprof_metadata_dialog_new (self->document);
gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (self));
gtk_window_present (GTK_WINDOW (dialog));
}
static void static void
sysprof_window_set_document (SysprofWindow *self, sysprof_window_set_document (SysprofWindow *self,
SysprofDocument *document) SysprofDocument *document)
@ -181,7 +164,6 @@ sysprof_window_class_init (SysprofWindowClass *klass)
gtk_widget_class_set_template_from_resource (widget_class, "/org/gnome/sysprof/sysprof-window.ui"); gtk_widget_class_set_template_from_resource (widget_class, "/org/gnome/sysprof/sysprof-window.ui");
gtk_widget_class_install_action (widget_class, "win.open-capture", NULL, sysprof_window_open_capture_action); gtk_widget_class_install_action (widget_class, "win.open-capture", NULL, sysprof_window_open_capture_action);
gtk_widget_class_install_action (widget_class, "capture.show-metadata", NULL, sysprof_window_show_metadata_action);
g_type_ensure (SYSPROF_TYPE_DOCUMENT); g_type_ensure (SYSPROF_TYPE_DOCUMENT);
g_type_ensure (SYSPROF_TYPE_FILES_SECTION); g_type_ensure (SYSPROF_TYPE_FILES_SECTION);

6
src/sysprof/sysprof-window.ui
View File

@ -161,12 +161,6 @@
<attribute name="label" translatable="yes">Record Again…</attribute> <attribute name="label" translatable="yes">Record Again…</attribute>
</item> </item>
</section> </section>
<section>
<item>
<attribute name="label" translatable="yes">Show Embedded Metadata…</attribute>
<attribute name="action">capture.show-metadata</attribute>
</item>
</section>
<section> <section>
<item> <item>
<attribute name="label" translatable="yes">Preferences</attribute> <attribute name="label" translatable="yes">Preferences</attribute>

1
src/sysprof/sysprof.gresource.xml
View File

@ -7,7 +7,6 @@
<file preprocess="xml-stripblanks">sysprof-greeter.ui</file> <file preprocess="xml-stripblanks">sysprof-greeter.ui</file>
<file preprocess="xml-stripblanks">sysprof-logs-section.ui</file> <file preprocess="xml-stripblanks">sysprof-logs-section.ui</file>
<file preprocess="xml-stripblanks">sysprof-marks-section.ui</file> <file preprocess="xml-stripblanks">sysprof-marks-section.ui</file>
<file preprocess="xml-stripblanks">sysprof-metadata-dialog.ui</file>
<file preprocess="xml-stripblanks">sysprof-metadata-section.ui</file> <file preprocess="xml-stripblanks">sysprof-metadata-section.ui</file>
<file preprocess="xml-stripblanks">sysprof-recording-pad.ui</file> <file preprocess="xml-stripblanks">sysprof-recording-pad.ui</file>
<file preprocess="xml-stripblanks">sysprof-samples-section.ui</file> <file preprocess="xml-stripblanks">sysprof-samples-section.ui</file>