varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-09 22:50:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof-analyze: insert and lookup ELF from cache

Browse Source 
We do need to at least translate the path to what we would want to see
from the host system before inserting/resolving, so that we don't risk
collisions in the cache.
This commit is contained in:
Christian Hergert
2023-05-19 13:50:46 -07:00
parent cb74b88b1b
commit 269a8ea658
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/libsysprof-analyze/sysprof-elf-loader.c
View File

@ -29,6 +29,7 @@
struct _SysprofElfLoader struct _SysprofElfLoader
{ {
GObject parent_instance; GObject parent_instance;
GHashTable *cache;
char **debug_dirs; char **debug_dirs;
char **external_debug_dirs; char **external_debug_dirs;
}; };
@ -59,6 +60,7 @@ sysprof_elf_loader_finalize (GObject *object)
g_clear_pointer (&self->debug_dirs, g_strfreev); g_clear_pointer (&self->debug_dirs, g_strfreev);
g_clear_pointer (&self->external_debug_dirs, g_strfreev); g_clear_pointer (&self->external_debug_dirs, g_strfreev);
g_clear_pointer (&self->cache, g_hash_table_unref);
G_OBJECT_CLASS (sysprof_elf_loader_parent_class)->finalize (object); G_OBJECT_CLASS (sysprof_elf_loader_parent_class)->finalize (object);
} }
@ -138,6 +140,7 @@ static void
sysprof_elf_loader_init (SysprofElfLoader *self) sysprof_elf_loader_init (SysprofElfLoader *self)
{ {
self->debug_dirs = g_strdupv ((char **)DEFAULT_DEBUG_DIRS); self->debug_dirs = g_strdupv ((char **)DEFAULT_DEBUG_DIRS);
self->cache = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, g_object_unref);
} }
/** /**
@ -299,12 +302,16 @@ sysprof_elf_loader_load (SysprofElfLoader *self,
g_autoptr(SysprofElf) elf = NULL; g_autoptr(SysprofElf) elf = NULL;
g_autoptr(GError) local_error = NULL; g_autoptr(GError) local_error = NULL;
g_autofree char *container_path = NULL; g_autofree char *container_path = NULL;
SysprofElf *cached_elf;
const char *path = paths[i]; const char *path = paths[i];
const char *debug_link; const char *debug_link;
if ((in_flatpak && !g_str_has_prefix (path, "/home/")) || in_podman) if ((in_flatpak && !g_str_has_prefix (path, "/home/")) || in_podman)
path = container_path = g_build_filename ("/var/run/host", path, NULL); path = container_path = g_build_filename ("/var/run/host", path, NULL);
if ((cached_elf = g_hash_table_lookup (self->cache, path)))
return g_object_ref (cached_elf);
if (!(mapped_file = g_mapped_file_new (path, FALSE, NULL))) if (!(mapped_file = g_mapped_file_new (path, FALSE, NULL)))
continue; continue;
@ -314,6 +321,8 @@ sysprof_elf_loader_load (SysprofElfLoader *self,
if ((debug_link = sysprof_elf_get_debug_link (elf))) if ((debug_link = sysprof_elf_get_debug_link (elf)))
sysprof_elf_loader_annotate (self, mount_namespace, elf, debug_link); sysprof_elf_loader_annotate (self, mount_namespace, elf, debug_link);
g_hash_table_insert (self->cache, g_strdup (path), g_object_ref (elf));
return g_steal_pointer (&elf); return g_steal_pointer (&elf);
} }