varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof: include process ID when cmdline is not available

Browse Source 
We shouldn't really hit this, but if we do, it's easy enough to synthesize
a real parent node for the process in question.
This commit is contained in:
Christian Hergert
2020-02-26 08:48:05 -08:00
parent d34e277a6a
commit 26bf532a8c
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/libsysprof/sysprof-callgraph-profile.c
View File

@ -339,6 +339,13 @@ sysprof_callgraph_profile_generate_worker (GTask *task,
cmdline = g_hash_table_lookup (cmdlines, GINT_TO_POINTER (sample->frame.pid)); cmdline = g_hash_table_lookup (cmdlines, GINT_TO_POINTER (sample->frame.pid));
if (cmdline == NULL)
{
gchar *pidstr = g_strdup_printf ("[Process %d]", sample->frame.pid);
g_hash_table_insert (cmdlines, GINT_TO_POINTER (sample->frame.pid), pidstr);
cmdline = pidstr;
}
#if 0 #if 0
/* This assertion appears to hold true, but since we're taking in /* This assertion appears to hold true, but since we're taking in
* untrusted data from capture files, it's not safe to assume. But in * untrusted data from capture files, it's not safe to assume. But in
@ -413,9 +420,7 @@ sysprof_callgraph_profile_generate_worker (GTask *task,
g_array_index (resolved, SysprofAddress, len++) = POINTER_TO_U64 (name); g_array_index (resolved, SysprofAddress, len++) = POINTER_TO_U64 (name);
} }
if (cmdline != NULL) g_array_index (resolved, guint64, len++) = POINTER_TO_U64 (cmdline);
g_array_index (resolved, guint64, len++) = POINTER_TO_U64 (cmdline);
g_array_index (resolved, guint64, len++) = POINTER_TO_U64 ("[Everything]"); g_array_index (resolved, guint64, len++) = POINTER_TO_U64 ("[Everything]");
stack_stash_add_trace (resolved_stash, (gpointer)resolved->data, len, 1); stack_stash_add_trace (resolved_stash, (gpointer)resolved->data, len, 1);