From 298f92ff2033b392bfd16dabb4591db4d7164735 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B8ren=20Sandmann=20Pedersen?= Date: Fri, 23 Apr 2010 11:26:17 -0400 Subject: [PATCH] Add FIXME about performance issue in stack_stash_add_trace() --- stackstash.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/stackstash.c b/stackstash.c index 8c06f7b4..44912e4b 100644 --- a/stackstash.c +++ b/stackstash.c @@ -220,6 +220,13 @@ stack_stash_add_trace (StackStash *stash, StackNode *match = NULL; StackNode *prev; + /* FIXME: On x86-64 we don't get proper stacktraces which means + * each node can have tons of children. That makes this loop + * here show up on profiles. + * + * Not sure what can be done about it aside from actually fixing + * x86-64 to get stacktraces. + */ prev = NULL; for (match = *location; match; prev = match, match = match->siblings) {