varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-10 07:00:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "sysprof/greeter: add external URLs configuration for debuginfod"

Browse Source 
This reverts commit b13d4acb98.
This commit is contained in:
varun-r-mallya
2025-02-03 21:34:43 +05:30
parent b13d4acb98
commit 333cd719f7
2 changed files with 4 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/sysprof/sysprof-greeter.ui
View File

@ -625,7 +625,7 @@
<object class="AdwActionRow"> <object class="AdwActionRow">
<property name="activatable-widget">debuginfod</property> <property name="activatable-widget">debuginfod</property>
<property name="title" translatable="yes">Debuginfod</property> <property name="title" translatable="yes">Debuginfod</property>
<property name="subtitle" translatable="yes">Enable Debuginfod to automatically fetch debug symbols</property> <property name="subtitle" translatable="yes">Enable Debuginfod</property>
<child type="suffix"> <child type="suffix">
<object class="GtkSwitch" id="debuginfod"> <object class="GtkSwitch" id="debuginfod">
<property name="active" bind-source="recording_template" bind-flags="bidirectional|sync-create" bind-property="debuginfod"/> <property name="active" bind-source="recording_template" bind-flags="bidirectional|sync-create" bind-property="debuginfod"/>
@ -636,27 +636,6 @@
</child> </child>
</object> </object>
</child> </child>
<child>
<object class="AdwPreferencesGroup">
<child>
<object class="AdwEntryRow" id="debuginfod_external_urls">
<property name="title" translatable="yes">Debuginfod External URLs</property>
<property name="text" bind-source="recording_template" bind-flags="bidirectional|sync-create" bind-property="debuginfod-external-urls"/>
</object>
</child>
<child>
<object class="GtkLabel">
<property name="label" translatable="yes">Comma-separated list of external debuginfod servers to query for debug information.</property>
<property name="xalign">0</property>
<property name="margin-top">8</property>
<style>
<class name="caption"/>
<class name="dim-label"/>
</style>
</object>
</child>
</object>
</child>
</object> </object>
</property> </property>
</object> </object>

20
src/sysprof/sysprof-recording-template.c
View File

@ -35,7 +35,6 @@ struct _SysprofRecordingTemplate
char *cwd; char *cwd;
char *power_profile; char *power_profile;
char **environ; char **environ;
char *debuginfod_external_urls;
guint stack_size; guint stack_size;
@ -66,7 +65,6 @@ enum {
PROP_BATTERY_CHARGE, PROP_BATTERY_CHARGE,
PROP_BUNDLE_SYMBOLS, PROP_BUNDLE_SYMBOLS,
PROP_DEBUGINFOD, PROP_DEBUGINFOD,
PROP_DEBUGINFOD_EXTERNAL_URLS,
PROP_CLEAR_ENVIRON, PROP_CLEAR_ENVIRON,
PROP_COMMAND_LINE, PROP_COMMAND_LINE,
PROP_CPU_USAGE, PROP_CPU_USAGE,
@ -105,7 +103,6 @@ sysprof_recording_template_finalize (GObject *object)
g_clear_pointer (&self->cwd, g_free); g_clear_pointer (&self->cwd, g_free);
g_clear_pointer (&self->power_profile, g_free); g_clear_pointer (&self->power_profile, g_free);
g_clear_pointer (&self->environ, g_free); g_clear_pointer (&self->environ, g_free);
g_clear_pointer (&self->debuginfod_external_urls, g_free);
G_OBJECT_CLASS (sysprof_recording_template_parent_class)->finalize (object); G_OBJECT_CLASS (sysprof_recording_template_parent_class)->finalize (object);
} }
@ -132,10 +129,6 @@ sysprof_recording_template_get_property (GObject *object,
g_value_set_boolean (value, self->debuginfod); g_value_set_boolean (value, self->debuginfod);
break; break;
case PROP_DEBUGINFOD_EXTERNAL_URLS:
g_value_set_string (value, self->debuginfod_external_urls);
break;
case PROP_CLEAR_ENVIRON: case PROP_CLEAR_ENVIRON:
g_value_set_boolean (value, self->clear_environ); g_value_set_boolean (value, self->clear_environ);
break; break;
@ -251,10 +244,6 @@ sysprof_recording_template_set_property (GObject *object,
self->debuginfod = g_value_get_boolean (value); self->debuginfod = g_value_get_boolean (value);
break; break;
case PROP_DEBUGINFOD_EXTERNAL_URLS:
g_set_str (&self->debuginfod_external_urls, g_value_get_string (value));
break;
case PROP_CLEAR_ENVIRON: case PROP_CLEAR_ENVIRON:
self->clear_environ = g_value_get_boolean (value); self->clear_environ = g_value_get_boolean (value);
break; break;
@ -373,11 +362,6 @@ sysprof_recording_template_class_init (SysprofRecordingTemplateClass *klass)
TRUE, TRUE,
(G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
properties[PROP_DEBUGINFOD_EXTERNAL_URLS] =
g_param_spec_string ("debuginfod-external-urls", NULL, NULL,
NULL,
(G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
properties[PROP_CLEAR_ENVIRON] = properties[PROP_CLEAR_ENVIRON] =
g_param_spec_boolean ("clear-environ", NULL, NULL, g_param_spec_boolean ("clear-environ", NULL, NULL,
FALSE, FALSE,
@ -507,7 +491,6 @@ sysprof_recording_template_init (SysprofRecordingTemplate *self)
self->system_log = TRUE; self->system_log = TRUE;
self->command_line = g_strdup (""); self->command_line = g_strdup ("");
self->cwd = g_strdup(""); self->cwd = g_strdup("");
self->debuginfod_external_urls = g_strdup("");
self->stack_size = DEFAULT_STACK_SIZE; self->stack_size = DEFAULT_STACK_SIZE;
} }
@ -642,6 +625,9 @@ sysprof_recording_template_apply (SysprofRecordingTemplate *self,
if (self->bundle_symbols) if (self->bundle_symbols)
sysprof_profiler_add_instrument (profiler, sysprof_symbols_bundle_new ()); sysprof_profiler_add_instrument (profiler, sysprof_symbols_bundle_new ());
// if (self->debuginfod) /*TODO: This just uses an a preexisting function.*/
// sysprof_profiler_add_instrument (profiler, this_should_be_a_handler_function());
if (self->cpu_usage) if (self->cpu_usage)
sysprof_profiler_add_instrument (profiler, sysprof_cpu_usage_new ()); sysprof_profiler_add_instrument (profiler, sysprof_cpu_usage_new ());