From 4a31b934be22e161eaaab70746cf9cafebdfb0bb Mon Sep 17 00:00:00 2001 From: Christian Hergert Date: Wed, 12 Jun 2019 11:13:44 -0700 Subject: [PATCH] tracefd: use g_strdup_printf() I don't like maintaining stack based string allocations unless it's really a performance savings. --- src/libsysprof/sysprof-tracefd-source.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsysprof/sysprof-tracefd-source.c b/src/libsysprof/sysprof-tracefd-source.c index 15c8e044..31197c71 100644 --- a/src/libsysprof/sysprof-tracefd-source.c +++ b/src/libsysprof/sysprof-tracefd-source.c @@ -168,7 +168,7 @@ sysprof_tracefd_source_modify_spawn (SysprofSource *source, { SysprofTracefdSource *self = (SysprofTracefdSource *)source; SysprofTracefdSourcePrivate *priv = sysprof_tracefd_source_get_instance_private (self); - gchar fdstr[12]; + g_autofree gchar *fdstr = NULL; gint dest_fd; gint fd; @@ -192,7 +192,7 @@ sysprof_tracefd_source_modify_spawn (SysprofSource *source, } dest_fd = sysprof_spawnable_take_fd (spawnable, fd, -1); - g_snprintf (fdstr, sizeof fdstr, "%d", dest_fd); + fdstr = g_strdup_printf ("%u", dest_fd); sysprof_spawnable_setenv (spawnable, priv->envvar, fdstr); }