From 4f270a0f4875620dfcf92d98c1bcf5961415e74a Mon Sep 17 00:00:00 2001 From: Soeren Sandmann Date: Wed, 2 Nov 2005 05:10:13 +0000 Subject: [PATCH] Update GUI after showing error message. 2005-11-01 Soeren Sandmann * sysprof.c (on_start_toggled): Update GUI after showing error message. * sysprof.glade: Rename File menu Profiler, move Start/Profile/Reset here, delete View menu. --- ChangeLog | 8 +++ TODO | 3 +- sysprof.c | 8 +-- sysprof.glade | 155 ++++++++++++++++++++++++-------------------------- 4 files changed, 88 insertions(+), 86 deletions(-) diff --git a/ChangeLog b/ChangeLog index 414ca873..ca76f43f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2005-11-01 Soeren Sandmann + + * sysprof.c (on_start_toggled): Update GUI after showing error + message. + + * sysprof.glade: Rename File menu Profiler, move + Start/Profile/Reset here, delete View menu. + Mon Oct 31 23:41:33 2005 Soeren Sandmann * stackstash.h (struct StackNode): Add "total" field. diff --git a/TODO b/TODO index 89ad414a..fbdd7e8a 100644 --- a/TODO +++ b/TODO @@ -117,7 +117,8 @@ Before 1.2: * Send entire stack to user space, then do stackwalking there. That would allow us to do more complex algorithms, like dwarf, in userspace. Though we'd lose the ability to do non-racy file naming. We could pass a list - of the process mappings with each stack though. + of the process mappings with each stack though. Doing this would also solve + the problem of not being able to get maps of processes running as root. * If interrupt happens in kernel mode, send both kernel stack and user space stack, have userspace stitch them diff --git a/sysprof.c b/sysprof.c index 8b915c36..74d3a86f 100644 --- a/sysprof.c +++ b/sysprof.c @@ -350,11 +350,11 @@ on_start_toggled (GtkWidget *widget, gpointer data) " modprobe sysprof-module\n" "\n" "as root."); - - return; } - - app->state = PROFILING; + else + { + app->state = PROFILING; + } update_sensitivity (app); } diff --git a/sysprof.glade b/sysprof.glade index c68756e3..724e5b81 100644 --- a/sysprof.glade +++ b/sysprof.glade @@ -32,12 +32,81 @@ True - _File + _Profiler True + + + True + _Start + True + + + + + True + gtk-media-play + 1 + 0.5 + 0.5 + 0 + 0 + + + + + + + + True + _Profile + True + + + + + True + gtk-justify-left + 1 + 0.5 + 0.5 + 0 + 0 + + + + + + + + True + _Reset + True + + + + + True + gtk-clear + 1 + 0.5 + 0.5 + 0 + 0 + + + + + + + + True + + + True @@ -47,7 +116,7 @@ - + True gtk-open 1 @@ -69,7 +138,7 @@ - + True gtk-save-as 1 @@ -97,7 +166,7 @@ - + True gtk-quit 1 @@ -114,82 +183,6 @@ - - - True - _View - True - - - - - - - True - _Start - True - - - - - True - gtk-media-play - 1 - 0.5 - 0.5 - 0 - 0 - - - - - - - - True - _Profile - True - - - - - True - gtk-justify-left - 1 - 0.5 - 0.5 - 0 - 0 - - - - - - - - True - _Reset - True - - - - - True - gtk-clear - 1 - 0.5 - 0.5 - 0 - 0 - - - - - - - - - True @@ -207,7 +200,7 @@ - + True gtk-about 1