varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-10 07:00:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof-analyze: short-circuit when address > max

Browse Source 
This adds an O(1) check at the head of the lookup to avoid looking at
every RB_RIGHT() in the tree when address falls beyond the upper bound of
the interval tree.
This commit is contained in:
Christian Hergert
2023-05-15 11:20:44 -07:00
parent 00ecc41209
commit 580889f8cb
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/libsysprof-analyze/sysprof-symbol-cache.c
View File

@ -178,6 +178,13 @@ sysprof_symbol_cache_lookup (SysprofSymbolCache *self,
node = RB_ROOT(&self->head); node = RB_ROOT(&self->head);
/* The root node contains our calculated max as augmented in RBTree.
* Therefore, we can know if @address falls beyond the upper bound
* in O(1) without having to add a branch to the while loop below.
*/
if (node == NULL || node->max < address)
return NULL;
while (node != NULL) while (node != NULL)
{ {
g_assert (RB_LEFT(node, link) == NULL || g_assert (RB_LEFT(node, link) == NULL ||