varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-12 16:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof: remove some weak pointer usage

Browse Source 
These are incredibly slow and just not worth the overhead of using weak
pointers for everything.

Fixes some jank on filtering function symbols.
This commit is contained in:
Christian Hergert
2023-07-25 20:32:21 -07:00
parent 64a5ab0018
commit 58b47cbe19
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libsysprof/sysprof-callgraph-symbol.c
View File

@ -48,7 +48,7 @@ sysprof_callgraph_symbol_finalize (GObject *object)
{ {
SysprofCallgraphSymbol *self = (SysprofCallgraphSymbol *)object; SysprofCallgraphSymbol *self = (SysprofCallgraphSymbol *)object;
g_clear_weak_pointer (&self->callgraph); g_clear_object (&self->callgraph);
g_clear_object (&self->symbol); g_clear_object (&self->symbol);
G_OBJECT_CLASS (sysprof_callgraph_symbol_parent_class)->finalize (object); G_OBJECT_CLASS (sysprof_callgraph_symbol_parent_class)->finalize (object);
@ -113,7 +113,7 @@ _sysprof_callgraph_symbol_new (SysprofCallgraph *callgraph,
g_return_val_if_fail (SYSPROF_IS_SYMBOL (symbol), NULL); g_return_val_if_fail (SYSPROF_IS_SYMBOL (symbol), NULL);
self = g_object_new (SYSPROF_TYPE_CALLGRAPH_SYMBOL, NULL); self = g_object_new (SYSPROF_TYPE_CALLGRAPH_SYMBOL, NULL);
g_set_weak_pointer (&self->callgraph, callgraph); g_set_object (&self->callgraph, callgraph);
g_set_object (&self->symbol, symbol); g_set_object (&self->symbol, symbol);
return self; return self;
@ -227,7 +227,7 @@ sysprof_callgraph_symbol_list_model_dispose (GObject *object)
SysprofCallgraphSymbolListModel *self = (SysprofCallgraphSymbolListModel *)object; SysprofCallgraphSymbolListModel *self = (SysprofCallgraphSymbolListModel *)object;
g_clear_pointer (&self->symbols, g_ptr_array_unref); g_clear_pointer (&self->symbols, g_ptr_array_unref);
g_clear_weak_pointer (&self->callgraph); g_clear_object (&self->callgraph);
G_OBJECT_CLASS (sysprof_callgraph_symbol_parent_class)->dispose (object); G_OBJECT_CLASS (sysprof_callgraph_symbol_parent_class)->dispose (object);
} }
@ -254,7 +254,7 @@ _sysprof_callgraph_symbol_list_model_new (SysprofCallgraph *callgraph,
g_return_val_if_fail (SYSPROF_IS_CALLGRAPH (callgraph), NULL); g_return_val_if_fail (SYSPROF_IS_CALLGRAPH (callgraph), NULL);
self = g_object_new (SYSPROF_TYPE_CALLGRAPH_SYMBOL_LIST_MODEL, NULL); self = g_object_new (SYSPROF_TYPE_CALLGRAPH_SYMBOL_LIST_MODEL, NULL);
g_set_weak_pointer (&self->callgraph, callgraph); g_set_object (&self->callgraph, callgraph);
if (symbols != NULL) if (symbols != NULL)
self->symbols = g_ptr_array_ref (symbols); self->symbols = g_ptr_array_ref (symbols);