varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-12 16:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

+2005-11-03 Soren Sandmann <sandmann@redhat.com>

Browse Source 
+
+       * configure.ac: Make the message about the kernel source package
+       more informative. Code from Kjetil Torgrim Homme.
+
+       * sysprof.c (on_start_toggled): Only delete the data if the
+       profiling can actually be started.
+
This commit is contained in:
Søren Sandmann Pedersen
2005-11-05 00:49:34 +00:00
parent 4f270a0f48
commit 5bddcf4af9
4 changed files with 28 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2005-11-03 Soren Sandmann <sandmann@redhat.com>
* configure.ac: Make the message about the kernel source package
more informative. Code from Kjetil Torgrim Homme.
* sysprof.c (on_start_toggled): Only delete the data if the
profiling can actually be started.
2005-11-01 Soeren Sandmann <sandmann@redhat.com> 2005-11-01 Soeren Sandmann <sandmann@redhat.com>
* sysprof.c (on_start_toggled): Update GUI after showing error * sysprof.c (on_start_toggled): Update GUI after showing error

7
TODO
View File

@ -13,8 +13,15 @@ Before 1.0.1:
Someone already did create a package - should be googlable. Someone already did create a package - should be googlable.
* Press start without kernel module loaded, then load kernel module and
press start again. Segmentation fault.
Before 1.2: Before 1.2:
* With kernel module not installed, select Profiler->Start, then dismiss
the alert. This causes the start button to appear prelighted. Probably
just another gtk+ bug.
* Don't build the GUI if gtk+ is not installed * Don't build the GUI if gtk+ is not installed
* Handle time being set back in the RESET_DEAD_PERIOD code. * Handle time being set back in the RESET_DEAD_PERIOD code.

6
configure.ac
View File

@ -69,9 +69,13 @@ if test $kernel_module = "yes"; then
fi fi
if [ ! test -f /lib/modules/`uname -r`/build/Makefile ] ; then if [ ! test -f /lib/modules/`uname -r`/build/Makefile ] ; then
case `uname -r` in
*smp) pkg=kernel-smp-devel ;;
*) pkg=kernel-devel ;;
esac
echo \* echo \*
echo \* Sysprof requires the kernel source code to be installed. echo \* Sysprof requires the kernel source code to be installed.
echo \* On a Fedora Core system the relevant package is kernel-devel echo \* On a Fedora Core system the relevant package is $pkg
echo \* echo \*
exit 1 exit 1
fi fi

9
sysprof.c
View File

@ -191,7 +191,8 @@ update_sensitivity (Application *app)
break; break;
} }
gtk_toggle_tool_button_set_active (GTK_TOGGLE_TOOL_BUTTON (active_radio_button), TRUE); gtk_toggle_tool_button_set_active (
GTK_TOGGLE_TOOL_BUTTON (active_radio_button), TRUE);
/* "profile" widgets */ /* "profile" widgets */
gtk_widget_set_sensitive (GTK_WIDGET (app->profile_button), gtk_widget_set_sensitive (GTK_WIDGET (app->profile_button),
@ -336,9 +337,9 @@ on_start_toggled (GtkWidget *widget, gpointer data)
if (!gtk_toggle_tool_button_get_active ( if (!gtk_toggle_tool_button_get_active (
GTK_TOGGLE_TOOL_BUTTON (app->start_button))) GTK_TOGGLE_TOOL_BUTTON (app->start_button)))
{
return; return;
}
delete_data (app);
/* FIXME: get the real error message */ /* FIXME: get the real error message */
if (!collector_start (app->collector, NULL)) if (!collector_start (app->collector, NULL))
@ -353,6 +354,8 @@ on_start_toggled (GtkWidget *widget, gpointer data)
} }
else else
{ {
delete_data (app);
app->state = PROFILING; app->state = PROFILING;
} }