varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof: avoid duplicate process records

Browse Source 
We want the first process record, but subsequent records should
be ignored, except that we want to take the appropriate comm[]
action from them.
This commit is contained in:
Christian Hergert
2023-09-01 14:09:17 -07:00
parent 30123284b6
commit 5f94e09f9c
3 changed files with 34 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/libsysprof/sysprof-document.c
View File

@ -803,11 +803,16 @@ static void
sysprof_document_load_processes (SysprofDocument *self)
{
G_GNUC_UNUSED SysprofProcessInfo *pid0;
g_autoptr(GHashTable) seen = NULL;
g_autoptr(EggBitset) duplicate = NULL;
EggBitsetIter iter;
guint i;
g_assert (SYSPROF_IS_DOCUMENT (self));
seen = g_hash_table_new (NULL, NULL);
duplicate = egg_bitset_new_empty ();
/* Always create PID 0 info */
pid0 = _sysprof_document_process_info (self, 0, TRUE);
@ -818,7 +823,7 @@ sysprof_document_load_processes (SysprofDocument *self)
g_autoptr(SysprofDocumentProcess) process = g_list_model_get_item (G_LIST_MODEL (self), i);
int pid = sysprof_document_frame_get_pid (SYSPROF_DOCUMENT_FRAME (process));
SysprofProcessInfo *process_info = _sysprof_document_process_info (self, pid, TRUE);
const char *cmdline = sysprof_document_process_get_command_line (process);
const char *cmdline = _sysprof_document_process_get_comm (process);
if (cmdline != NULL)
{
@ -836,9 +841,19 @@ sysprof_document_load_processes (SysprofDocument *self)
NULL, NULL, 0, 0,
SYSPROF_SYMBOL_KIND_PROCESS);
}
/* Only include the first process discover for this process,
* ignore all secondary notations which are just comm[] updates.
*/
if (g_hash_table_contains (seen, GINT_TO_POINTER (pid)))
egg_bitset_add (duplicate, i);
else
g_hash_table_add (seen, GINT_TO_POINTER (pid));
}
while (egg_bitset_iter_next (&iter, &i));
}
egg_bitset_subtract (self->processes, duplicate);
}
static void