varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-11 23:51:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Comment out debug spew. (elf_parser_lookup_symbol): Add check that address

Browse Source 
2006-08-20  Soren Sandmann  <sandmann@daimi.au.dk>

	* elfparser.c (elf_parser_get_load_address): Comment out debug spew.
	(elf_parser_lookup_symbol): Add check that address is actually
	within the bounds of the found function.
This commit is contained in:
Soren Sandmann
2006-08-21 03:34:44 +00:00
committed by Søren Sandmann Pedersen
parent a880ee7f60
commit 66a28bd501
2 changed files with 27 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
2006-08-20 Soren Sandmann <sandmann@daimi.au.dk>
* elfparser.c (elf_parser_get_load_address): Comment out debug spew.
(elf_parser_lookup_symbol): Add check that address is actually
within the bounds of the found function.
2006-08-20 Soren Sandmann <sandmann@daimi.au.dk> 2006-08-20 Soren Sandmann <sandmann@daimi.au.dk>
* process.h: Make process_lookup_symbol() return a string. Delete * process.h: Make process_lookup_symbol() return a string. Delete

25
elfparser.c
View File

@ -411,7 +411,9 @@ elf_parser_get_load_address (ElfParser *parser)
} }
} }
#if 0
g_print ("load address is: %8p\n", (void *)load_address); g_print ("load address is: %8p\n", (void *)load_address);
#endif
return load_address; return load_address;
} }
@ -453,6 +455,9 @@ const ElfSym *
elf_parser_lookup_symbol (ElfParser *parser, elf_parser_lookup_symbol (ElfParser *parser,
gulong address) gulong address)
{ {
const ElfSym *result;
gsize size;
if (!parser->symbols) if (!parser->symbols)
read_symbols (parser); read_symbols (parser);
@ -465,10 +470,22 @@ elf_parser_lookup_symbol (ElfParser *parser,
g_print ("the address we are looking up is %p\n", address); g_print ("the address we are looking up is %p\n", address);
#endif #endif
/* FIXME: we should look at the symbol size and check if the result = do_lookup (parser->symbols, address, 0, parser->n_symbols - 1);
* address is actually within the function.
*/ if (result)
return do_lookup (parser->symbols, address, 0, parser->n_symbols - 1); {
/* Check that address is actually within the function */
bin_parser_begin (parser->parser, parser->sym_format, result->offset);
size = bin_parser_get_uint (parser->parser, "st_size");
if (result->address + size > address)
result = NULL;
bin_parser_end (parser->parser);
}
return result;
} }
static ElfParser * static ElfParser *