varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-09 22:50:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better handling of events without stacktraces

Browse Source
This commit is contained in:
Søren Sandmann Pedersen
2009-09-08 02:59:04 -04:00
parent 23147e1141
commit 6dabcefec5
3 changed files with 23 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
TODO
View File

@ -23,6 +23,8 @@ Before 1.0.4:
Before 1.2: Before 1.2:
* Hack around gtk+ bug where it mispositions the window.
* Counters must not be destroyed during tracker setup. They have to exist * Counters must not be destroyed during tracker setup. They have to exist
but be disabled so that we can track creation of processes. but be disabled so that we can track creation of processes.

24
collector.c
View File

@ -237,7 +237,7 @@ on_read (gpointer data)
skip_samples = in_dead_period (collector); skip_samples = in_dead_period (collector);
while (head - tail >= sizeof (struct perf_event_header)) while (head - tail >= sizeof (struct perf_event_header))
{ {
struct perf_event_header *header = (void *)(counter->data + (tail & mask)); struct perf_event_header *header = (void *)(counter->data + (tail & mask));
if (header->size > head - tail) if (header->size > head - tail)
@ -473,10 +473,28 @@ process_sample (Collector *collector,
{ {
uint64_t *ips; uint64_t *ips;
int n_ips; int n_ips;
if (sample->n_ips == 0) if (sample->n_ips == 0)
{ {
ips = &sample->ip; uint64_t trace[3];
n_ips = 1;
if (sample->header.misc & PERF_EVENT_MISC_KERNEL)
{
trace[0] = PERF_CONTEXT_KERNEL;
trace[1] = sample->ip;
trace[2] = PERF_CONTEXT_USER;
ips = trace;
n_ips = 3;
}
else
{
trace[0] = PERF_CONTEXT_USER;
trace[1] = sample->ip;
ips = trace;
n_ips = 2;
}
} }
else else
{ {

2
tracker.c
View File

@ -295,8 +295,6 @@ tracker_add_process (tracker_t * tracker,
COPY_STRING (event.command_line, command_line); COPY_STRING (event.command_line, command_line);
tracker_append (tracker, &event, sizeof (event)); tracker_append (tracker, &event, sizeof (event));
g_print ("Added new process: %d (%s)\n", pid, command_line);
} }
void void