varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-12 16:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof: guard message string and dup contents

Browse Source
This commit is contained in:
Christian Hergert
2024-11-26 21:46:54 -08:00
parent 252d627888
commit 6f5d119539
2 changed files with 31 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/libsysprof/sysprof-document-loader.c
View File

@ -263,7 +263,7 @@ sysprof_document_loader_get_property (GObject *object,
break; break;
case PROP_MESSAGE: case PROP_MESSAGE:
g_value_set_string (value, sysprof_document_loader_get_message (self)); g_value_take_string (value, sysprof_document_loader_dup_message (self));
break; break;
case PROP_SYMBOLIZER: case PROP_SYMBOLIZER:
@ -445,14 +445,39 @@ sysprof_document_loader_get_fraction (SysprofDocumentLoader *self)
* This only updates between calls of sysprof_document_loader_load_async() * This only updates between calls of sysprof_document_loader_load_async()
* and sysprof_document_loader_load_finish(). * and sysprof_document_loader_load_finish().
* *
* Returns: (nullable): a string containing a load message * Returns: (nullable): %NULL
*/ */
const char * const char *
sysprof_document_loader_get_message (SysprofDocumentLoader *self) sysprof_document_loader_get_message (SysprofDocumentLoader *self)
{ {
g_return_val_if_fail (SYSPROF_IS_DOCUMENT_LOADER (self), NULL); g_return_val_if_fail (SYSPROF_IS_DOCUMENT_LOADER (self), NULL);
return self->message; return NULL;
}
/**
* sysprof_document_loader_dup_message:
* @self: a #SysprofDocumentLoader
*
* Gets a text message representing what is happenin with loading.
*
* This only updates between calls of sysprof_document_loader_load_async()
* and sysprof_document_loader_load_finish().
*
* Returns: (nullable) (transfer full): a string or %NULL
*/
char *
sysprof_document_loader_dup_message (SysprofDocumentLoader *self)
{
char *ret;
g_return_val_if_fail (SYSPROF_IS_DOCUMENT_LOADER (self), NULL);
g_mutex_lock (&self->mutex);
ret = g_strdup (self->message);
g_mutex_unlock (&self->mutex);
return ret;
} }
static void static void

4
src/libsysprof/sysprof-document-loader.h
View File

@ -46,7 +46,9 @@ void sysprof_document_loader_set_symbolizer (SysprofDocumentLo
SysprofSymbolizer *symbolizer); SysprofSymbolizer *symbolizer);
SYSPROF_AVAILABLE_IN_ALL SYSPROF_AVAILABLE_IN_ALL
double sysprof_document_loader_get_fraction (SysprofDocumentLoader *self); double sysprof_document_loader_get_fraction (SysprofDocumentLoader *self);
SYSPROF_AVAILABLE_IN_ALL SYSPROF_AVAILABLE_IN_48
char *sysprof_document_loader_dup_message (SysprofDocumentLoader *self);
SYSPROF_DEPRECATED_IN_48_FOR(sysprof_document_loader_dup_message)
const char *sysprof_document_loader_get_message (SysprofDocumentLoader *self); const char *sysprof_document_loader_get_message (SysprofDocumentLoader *self);
SYSPROF_AVAILABLE_IN_48 SYSPROF_AVAILABLE_IN_48
GListModel *sysprof_document_loader_list_tasks (SysprofDocumentLoader *self); GListModel *sysprof_document_loader_list_tasks (SysprofDocumentLoader *self);