varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-12 16:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof: sort indexes by size from smallest

Browse Source 
This is just to help ensure we are not doing extra work that would fall
out of the visible range of the index.
This commit is contained in:
Christian Hergert
2023-07-31 12:07:17 -07:00
parent dc2d7b983f
commit 6f6228b1b5
1 changed files with 40 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
src/libsysprof/sysprof-callgraph-frame.c
View File

@ -381,6 +381,24 @@ filter_by_prefix_worker (GTask *task,
g_object_unref); g_object_unref);
} }
static int
sort_by_size_asc (gconstpointer a,
gconstpointer b)
{
const EggBitset *bitset_a = *(const EggBitset * const *)a;
const EggBitset *bitset_b = *(const EggBitset * const *)a;
gsize size_a = egg_bitset_get_size (bitset_a);
gsize size_b = egg_bitset_get_size (bitset_b);
if (size_a < size_b)
return -1;
if (size_a > size_b)
return 1;
return 0;
}
/** /**
* sysprof_callgraph_frame_list_traceables: * sysprof_callgraph_frame_list_traceables:
* @self: a #SysprofCallgraphFrame * @self: a #SysprofCallgraphFrame
@ -398,6 +416,7 @@ sysprof_callgraph_frame_list_traceables_async (SysprofCallgraphFrame *self,
{ {
g_autoptr(GTask) task = NULL; g_autoptr(GTask) task = NULL;
g_autoptr(GPtrArray) prefix = NULL; g_autoptr(GPtrArray) prefix = NULL;
g_autoptr(GPtrArray) bitsets = NULL;
g_autoptr(EggBitset) bitset = NULL; g_autoptr(EggBitset) bitset = NULL;
FilterByPrefix *state; FilterByPrefix *state;
@ -417,6 +436,7 @@ sysprof_callgraph_frame_list_traceables_async (SysprofCallgraphFrame *self,
} }
prefix = g_ptr_array_new (); prefix = g_ptr_array_new ();
bitsets = g_ptr_array_new ();
for (SysprofCallgraphNode *node = self->node; for (SysprofCallgraphNode *node = self->node;
node != NULL; node != NULL;
@ -429,15 +449,28 @@ sysprof_callgraph_frame_list_traceables_async (SysprofCallgraphFrame *self,
symbol->kind != SYSPROF_SYMBOL_KIND_KERNEL) symbol->kind != SYSPROF_SYMBOL_KIND_KERNEL)
continue; continue;
if (bitset == NULL) g_ptr_array_add (bitsets, summary->traceables);
bitset = egg_bitset_copy (summary->traceables);
else
egg_bitset_intersect (bitset, summary->traceables);
g_ptr_array_add (prefix, symbol); g_ptr_array_add (prefix, symbol);
} }
if (prefix->len == 0 || egg_bitset_is_empty (bitset)) if (prefix->len == 0)
{
g_task_return_pointer (task,
g_list_store_new (SYSPROF_TYPE_DOCUMENT_TRACEABLE),
g_object_unref);
return;
}
/* Sort the bitsets by size to shrink potential interscetions */
g_ptr_array_sort (bitsets, sort_by_size_asc);
bitset = egg_bitset_copy (g_ptr_array_index (bitsets, 0));
for (guint i = 1; i < bitsets->len; i++)
{
const EggBitset *other = g_ptr_array_index (bitsets, i);
egg_bitset_intersect (bitset, other);
}
if (egg_bitset_is_empty (bitset))
{ {
g_task_return_pointer (task, g_task_return_pointer (task,
g_list_store_new (SYSPROF_TYPE_DOCUMENT_TRACEABLE), g_list_store_new (SYSPROF_TYPE_DOCUMENT_TRACEABLE),
@ -449,7 +482,7 @@ sysprof_callgraph_frame_list_traceables_async (SysprofCallgraphFrame *self,
state->document = g_object_ref (self->callgraph->document); state->document = g_object_ref (self->callgraph->document);
state->traceables = g_object_ref (self->callgraph->traceables); state->traceables = g_object_ref (self->callgraph->traceables);
state->prefix = g_steal_pointer (&prefix); state->prefix = g_steal_pointer (&prefix);
state->bitset = egg_bitset_ref (bitset); state->bitset = g_steal_pointer (&bitset);
g_task_set_task_data (task, state, (GDestroyNotify)filter_by_prefix_free); g_task_set_task_data (task, state, (GDestroyNotify)filter_by_prefix_free);
g_task_run_in_thread (task, filter_by_prefix_worker); g_task_run_in_thread (task, filter_by_prefix_worker);