From 71a2404d6efb45f7faffce2fa786172986597e12 Mon Sep 17 00:00:00 2001
From: Christian Hergert <chergert@redhat.com>
Date: Mon, 21 Aug 2023 15:40:51 -0700
Subject: [PATCH] sysprof: include boudaries by default

This will help with graphs where we want to show things which will overlap
the edges.
---
 src/sysprof/sysprof-time-filter-model.c | 38 +++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/src/sysprof/sysprof-time-filter-model.c b/src/sysprof/sysprof-time-filter-model.c
index c931041e..4a216563 100644
--- a/src/sysprof/sysprof-time-filter-model.c
+++ b/src/sysprof/sysprof-time-filter-model.c
@@ -30,16 +30,20 @@ struct _SysprofTimeFilterModel
   GtkExpression     *expression;
   GtkSliceListModel *slice;
   SysprofTimeSpan    time_span;
+  guint              inclusive : 1;
 };
 
 enum {
   PROP_0,
   PROP_EXPRESSION,
+  PROP_INCLUSIVE,
   PROP_MODEL,
   PROP_TIME_SPAN,
   N_PROPS
 };
 
+static void sysprof_time_filter_model_update (SysprofTimeFilterModel *self);
+
 static GType
 sysprof_time_filter_model_get_item_type (GListModel *model)
 {
@@ -108,6 +112,10 @@ sysprof_time_filter_model_get_property (GObject    *object,
       gtk_value_set_expression (value, sysprof_time_filter_model_get_expression (self));
       break;
 
+    case PROP_INCLUSIVE:
+      g_value_set_boolean (value, self->inclusive);
+      break;
+
     case PROP_MODEL:
       g_value_set_object (value, sysprof_time_filter_model_get_model (self));
       break;
@@ -135,6 +143,11 @@ sysprof_time_filter_model_set_property (GObject      *object,
       sysprof_time_filter_model_set_expression (self, gtk_value_get_expression (value));
       break;
 
+    case PROP_INCLUSIVE:
+      self->inclusive = g_value_get_boolean (value);
+      sysprof_time_filter_model_update (self);
+      break;
+
     case PROP_MODEL:
       sysprof_time_filter_model_set_model (self, g_value_get_object (value));
       break;
@@ -161,6 +174,17 @@ sysprof_time_filter_model_class_init (SysprofTimeFilterModelClass *klass)
     gtk_param_spec_expression ("expression", NULL, NULL,
                                (G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS));
 
+  /**
+   * SysprofTimeFilterModel:inclusive:
+   *
+   * If we're inclusive of items that are off the edge of the
+   * boundaries.
+   */
+  properties[PROP_INCLUSIVE] =
+    g_param_spec_boolean ("inclusive", NULL, NULL,
+                          TRUE,
+                          (G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS));
+
   properties[PROP_MODEL] =
     g_param_spec_object ("model", NULL, NULL,
                          G_TYPE_LIST_MODEL,
@@ -178,6 +202,7 @@ static void
 sysprof_time_filter_model_init (SysprofTimeFilterModel *self)
 {
   self->expression = gtk_property_expression_new (SYSPROF_TYPE_DOCUMENT_FRAME, NULL, "time");
+  self->inclusive = TRUE;
 
   self->time_span.begin_nsec = G_MININT64;
   self->time_span.end_nsec = G_MAXINT64;
@@ -368,6 +393,19 @@ sysprof_time_filter_model_update (SysprofTimeFilterModel *self)
 
   calculate_bounds (self, model, &self->time_span, &offset, &size);
 
+  /* We want to extend our selection to adjacent values so that we
+   * are more likely to include enough data to overlap the boundaries
+   * when drawing graphs.
+   *
+   * This can sort of muck up callgraphs, so it's disabled in those.
+   */
+  if (self->inclusive)
+    {
+      if (offset > 0)
+        offset--;
+      size++;
+    }
+
   gtk_slice_list_model_set_offset (self->slice, offset);
   gtk_slice_list_model_set_size (self->slice, size);
 }