From 739ff7b19c133a27add943da4a8fd8747653f3a7 Mon Sep 17 00:00:00 2001
From: Christian Hergert <chergert@redhat.com>
Date: Fri, 9 Jun 2023 15:59:21 -0700
Subject: [PATCH] libsysprof-gtk: make some column values show up

---
 .../sysprof-weighted-callgraph-view.c         | 52 ++++++++++++++++++-
 .../sysprof-weighted-callgraph-view.ui        | 27 +++++++++-
 2 files changed, 76 insertions(+), 3 deletions(-)

diff --git a/src/libsysprof-gtk/sysprof-weighted-callgraph-view.c b/src/libsysprof-gtk/sysprof-weighted-callgraph-view.c
index 9a4227f6..884a49da 100644
--- a/src/libsysprof-gtk/sysprof-weighted-callgraph-view.c
+++ b/src/libsysprof-gtk/sysprof-weighted-callgraph-view.c
@@ -61,20 +61,66 @@ augment_weight (SysprofCallgraph     *callgraph,
 
   cur = sysprof_callgraph_get_augment (callgraph, node);
   cur->size += 1;
+  cur->total += 1;
 
   sum = sysprof_callgraph_get_summary_augment (callgraph, node);
   sum->size += 1;
+  sum->total += 1;
 
-  for (; node; node = sysprof_callgraph_node_parent (node))
+  for (node = sysprof_callgraph_node_parent (node);
+       node != NULL;
+       node = sysprof_callgraph_node_parent (node))
     {
       cur = sysprof_callgraph_get_augment (callgraph, node);
       cur->total += 1;
 
       sum = sysprof_callgraph_get_summary_augment (callgraph, node);
-      sum->size += 1;
+      sum->total += 1;
     }
 }
 
+static double
+get_total_fraction (GObject *item)
+{
+  g_autoptr(GObject) row = NULL;
+
+  g_object_get (item, "item", &row, NULL);
+
+  if (GTK_IS_TREE_LIST_ROW (row))
+    {
+      GtkTreeListRow *tree_row = GTK_TREE_LIST_ROW (row);
+      SysprofCallgraphFrame *frame = SYSPROF_CALLGRAPH_FRAME (gtk_tree_list_row_get_item (tree_row));
+      SysprofCallgraph *callgraph = sysprof_callgraph_frame_get_callgraph (frame);
+      AugmentWeight *sum = sysprof_callgraph_frame_get_augment (frame);
+      AugmentWeight *root = sysprof_callgraph_get_augment (callgraph, NULL);
+
+      return (double)sum->total / (double)root->total;
+    }
+
+  return 0;
+}
+
+static double
+get_self_fraction (GObject *item)
+{
+  g_autoptr(GObject) row = NULL;
+
+  g_object_get (item, "item", &row, NULL);
+
+  if (GTK_IS_TREE_LIST_ROW (row))
+    {
+      GtkTreeListRow *tree_row = GTK_TREE_LIST_ROW (row);
+      SysprofCallgraphFrame *frame = SYSPROF_CALLGRAPH_FRAME (gtk_tree_list_row_get_item (tree_row));
+      SysprofCallgraph *callgraph = sysprof_callgraph_frame_get_callgraph (frame);
+      AugmentWeight *sum = sysprof_callgraph_frame_get_augment (frame);
+      AugmentWeight *root = sysprof_callgraph_get_augment (callgraph, NULL);
+
+      return sum->size / (double)root->total;
+    }
+
+  return .0;
+}
+
 static void
 sysprof_weighted_callgraph_view_class_init (SysprofWeightedCallgraphViewClass *klass)
 {
@@ -87,6 +133,8 @@ sysprof_weighted_callgraph_view_class_init (SysprofWeightedCallgraphViewClass *k
   gtk_widget_class_set_template_from_resource (widget_class, "/libsysprof-gtk/sysprof-weighted-callgraph-view.ui");
   gtk_widget_class_bind_template_child (widget_class, SysprofWeightedCallgraphView, self_column);
   gtk_widget_class_bind_template_child (widget_class, SysprofWeightedCallgraphView, total_column);
+  gtk_widget_class_bind_template_callback (widget_class, get_self_fraction);
+  gtk_widget_class_bind_template_callback (widget_class, get_total_fraction);
 
   g_type_ensure (SYSPROF_TYPE_PROGRESS_CELL);
 }
diff --git a/src/libsysprof-gtk/sysprof-weighted-callgraph-view.ui b/src/libsysprof-gtk/sysprof-weighted-callgraph-view.ui
index fc612f14..8609968b 100644
--- a/src/libsysprof-gtk/sysprof-weighted-callgraph-view.ui
+++ b/src/libsysprof-gtk/sysprof-weighted-callgraph-view.ui
@@ -6,6 +6,27 @@
         <child>
           <object class="GtkColumnViewColumn" id="self_column">
             <property name="title" translatable="yes">Self</property>
+            <property name="factory">
+              <object class="GtkBuilderListItemFactory">
+                <property name="bytes"><![CDATA[
+<?xml version="1.0" encoding="UTF-8"?>
+<interface>
+  <template class="GtkListItem">
+    <property name="child">
+      <object class="SysprofProgressCell" id="progress">
+        <binding name="fraction">
+          <closure type="gdouble" function="get_self_fraction">
+            <lookup name="item">GtkListItem</lookup>
+          </closure>
+        </binding>
+      </object>
+    </property>
+  </template>
+</interface>
+]]>
+                </property>
+              </object>
+            </property>
           </object>
         </child>
         <child>
@@ -19,7 +40,11 @@
   <template class="GtkListItem">
     <property name="child">
       <object class="SysprofProgressCell" id="progress">
-        <property name="fraction">.50</property>
+        <binding name="fraction">
+          <closure type="gdouble" function="get_total_fraction">
+            <lookup name="item">GtkListItem</lookup>
+          </closure>
+        </binding>
       </object>
     </property>
   </template>