From 77cf99850f9871418b0bd967729bf7328c9bef8b Mon Sep 17 00:00:00 2001 From: Christian Hergert Date: Mon, 22 May 2023 12:21:51 -0700 Subject: [PATCH] libsysprof-analyze: use switch/jumptable --- src/libsysprof-analyze/sysprof-document.c | 37 ++++++++++++++++------- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/src/libsysprof-analyze/sysprof-document.c b/src/libsysprof-analyze/sysprof-document.c index f1f1a80a..70a09f6c 100644 --- a/src/libsysprof-analyze/sysprof-document.c +++ b/src/libsysprof-analyze/sysprof-document.c @@ -487,17 +487,32 @@ sysprof_document_load_worker (GTask *task, gtk_bitset_add (self->pids, pid); - if (tainted->type == SYSPROF_CAPTURE_FRAME_SAMPLE || - tainted->type == SYSPROF_CAPTURE_FRAME_ALLOCATION) - gtk_bitset_add (self->traceables, self->frames->len); - else if (tainted->type == SYSPROF_CAPTURE_FRAME_PROCESS) - gtk_bitset_add (self->processes, self->frames->len); - else if (tainted->type == SYSPROF_CAPTURE_FRAME_FILE_CHUNK) - gtk_bitset_add (self->file_chunks, self->frames->len); - else if (tainted->type == SYSPROF_CAPTURE_FRAME_MAP) - gtk_bitset_add (self->mmaps, self->frames->len); - else if (tainted->type == SYSPROF_CAPTURE_FRAME_OVERLAY) - gtk_bitset_add (self->overlays, self->frames->len); + switch ((int)tainted->type) + { + case SYSPROF_CAPTURE_FRAME_ALLOCATION: + case SYSPROF_CAPTURE_FRAME_SAMPLE: + gtk_bitset_add (self->traceables, self->frames->len); + break; + + case SYSPROF_CAPTURE_FRAME_PROCESS: + gtk_bitset_add (self->processes, self->frames->len); + break; + + case SYSPROF_CAPTURE_FRAME_FILE_CHUNK: + gtk_bitset_add (self->file_chunks, self->frames->len); + break; + + case SYSPROF_CAPTURE_FRAME_MAP: + gtk_bitset_add (self->mmaps, self->frames->len); + break; + + case SYSPROF_CAPTURE_FRAME_OVERLAY: + gtk_bitset_add (self->overlays, self->frames->len); + break; + + default: + break; + } if (tainted->type == SYSPROF_CAPTURE_FRAME_FILE_CHUNK) {