varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-12 16:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

sysprof-greeter: optimize environment variable handling in profiler creation

Browse Source 
Signed-off-by: varun-r-mallya <varunrmallya@gmail.com>
This commit is contained in:
varun-r-mallya
2025-03-06 17:57:01 +05:30
parent 775d7ae5eb
commit 8186cc464a
1 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/sysprof/sysprof-greeter.c
View File

@ -205,16 +205,15 @@ sysprof_greeter_create_profiler (SysprofGreeter *self,
g_autoptr(GFile) dir = NULL; g_autoptr(GFile) dir = NULL;
GtkStringObject *strobj; GtkStringObject *strobj;
const char *str; const char *str;
guint envvars_n_items;
g_autoptr(GStrvBuilder) envvars_builder = NULL;
g_autofree GStrv envvars_list = NULL;
g_assert (SYSPROF_IS_GREETER (self)); g_assert (SYSPROF_IS_GREETER (self));
if ((envvars_n_items = g_list_model_get_n_items (G_LIST_MODEL (self->envvars)))) if (g_list_model_get_n_items (G_LIST_MODEL (self->envvars)))
{ {
envvars_builder = g_strv_builder_new (); g_autoptr(GStrvBuilder) envvars_builder = g_strv_builder_new ();;
for (guint i = 0; i < envvars_n_items; i++) g_auto(GStrv) envvars_list = NULL;
for (guint i = 0; i < g_list_model_get_n_items (G_LIST_MODEL (self->envvars)); i++)
{ {
strobj = g_list_model_get_item (G_LIST_MODEL (self->envvars), i); strobj = g_list_model_get_item (G_LIST_MODEL (self->envvars), i);
g_strv_builder_add (envvars_builder, gtk_string_object_get_string (strobj)); g_strv_builder_add (envvars_builder, gtk_string_object_get_string (strobj));
@ -632,11 +631,9 @@ sysprof_greeter_init (SysprofGreeter *self)
if (environ) if (environ)
{ {
for (guint i = 0; environ[i]; i++) for (guint i = 0; environ[i]; i++)
{
gtk_string_list_append (self->envvars, environ[i]); gtk_string_list_append (self->envvars, environ[i]);
} }
} }
}
row = gtk_list_box_get_row_at_index (self->sidebar_list_box, 0); row = gtk_list_box_get_row_at_index (self->sidebar_list_box, 0);
gtk_list_box_select_row (self->sidebar_list_box, row); gtk_list_box_select_row (self->sidebar_list_box, row);