varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

sysprof-cli: Don't overwrite capture file by default

Browse Source 
Add -f / --force to allow overwrite

https://bugzilla.gnome.org/show_bug.cgi?id=775062
This commit is contained in:
Hubert Figuière
2016-11-26 10:03:21 -05:00
parent 563a5e3e65
commit 87289e0421
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tools/sysprof-cli.c
View File

@ -89,11 +89,14 @@ main (gint argc,
GSource *gsource;
gchar *command = NULL;
gboolean version = FALSE;
gboolean force = FALSE;
int pid = -1;
int fd;
int flags;
GOptionEntry entries[] = {
{ "pid", 'p', 0, G_OPTION_ARG_INT, &pid, N_("Make sysprof specific to a task"), N_("PID") },
{ "command", 'c', 0, G_OPTION_ARG_STRING, &command, N_("Run a command and profile the process"), N_("COMMAND") },
{ "force", 'f', 0, G_OPTION_ARG_NONE, &force, N_("Force overwrite the capture file") },
{ "version", 0, 0, G_OPTION_ARG_NONE, &version, N_("Print the sysprof-cli version and exit") },
{ NULL }
};
@ -151,7 +154,19 @@ main (gint argc,
if (argc == 2)
filename = argv[1];
if (-1 == (fd = g_open (filename, O_CREAT | O_RDWR | O_CLOEXEC, 0640)))
flags = O_CREAT | O_RDWR | O_CLOEXEC;
if (!force)
{
/* if we don't force overwrite we want to ensure the file doesn't exist
* and never overwrite it. O_EXCL will prevent opening in that case */
flags |= O_EXCL;
if (g_file_test (filename, G_FILE_TEST_EXISTS))
{
g_printerr (_("%s exists. Use --force to overwrite\n"), filename);
return EXIT_FAILURE;
}
}
if (-1 == (fd = g_open (filename, flags, 0640)))
{
g_printerr ("Failed to open %s\n", filename);
return EXIT_FAILURE;