From 9125c4e644fa8168b6f6b15f06cda7423deec996 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B8ren=20Sandmann?= Date: Sat, 14 Jan 2006 04:12:12 +0000 Subject: [PATCH] updates MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fri Jan 13 23:11:33 2006 Søren Sandmann * TODO: updates --- ChangeLog | 4 ++++ TODO | 3 +++ collector.c | 4 +--- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index c95775d7..09caba78 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +Fri Jan 13 23:11:33 2006 Søren Sandmann + + * TODO: updates + Fri Jan 13 22:59:48 2006 Soeren Sandmann * module/sysprof-module.c (sysprof_open): Initialize retval. diff --git a/TODO b/TODO index 3b57ab00..d7f56ae1 100644 --- a/TODO +++ b/TODO @@ -129,6 +129,7 @@ Before 1.2: we'd lose the ability to do non-racy file naming. We could pass a list of the process mappings with each stack though. Doing this would also solve the problem of not being able to get maps of processes running as root. + Might be too expensive though. * If interrupt happens in kernel mode, send both kernel stack and user space stack, have userspace stitch them @@ -420,6 +421,8 @@ Later: DONE: +* Find out why we sometimes get reports of time spent by [pid 0]. + * - Run a.out generated normally with gcc. - Run sysprof - hit profile diff --git a/collector.c b/collector.c index fd486a9b..0acd2fd1 100644 --- a/collector.c +++ b/collector.c @@ -182,7 +182,7 @@ open_fd (Collector *collector, while (fd < 0 && g_timer_elapsed (timer, NULL) < 0.5) { - /* Give udev time to create the device */ + /* Wait for udev to discover the new device */ usleep (100000); fd = open (SYSPROF_FILE, O_RDONLY); @@ -196,8 +196,6 @@ open_fd (Collector *collector, } } - /* Wait for udev to discover the new device */ - if (fd < 0) { /* FIXME: set error */