varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-12 08:00:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof-analyze: include binary path basename in hash

Browse Source 
This helps improve the chances that we get a match on "libfoo.so" and the
symbol name within it.
This commit is contained in:
Christian Hergert
2023-06-12 17:21:28 -07:00
parent 535c7be1e4
commit a3df31c246
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/libsysprof-analyze/sysprof-symbol.c
View File

@ -146,6 +146,21 @@ _sysprof_symbol_new (GRefString *name,
self->end_address = end_address; self->end_address = end_address;
self->hash = g_str_hash (name); self->hash = g_str_hash (name);
/* If we got a path for the symbol, add that to the hash so that we
* can be sure that we're working with a symbol in the same file when
* there are collisions.
*
* That way, we have a chance of joining symbols from different runtimes
* and/or containers, but only if they are reasonably the same ABI.
*/
if (binary_path != NULL)
{
const char *base = strrchr (binary_path, '/');
if (base != NULL)
self->hash ^= g_str_hash (base);
}
return self; return self;
} }