From a67701848dfe0f5ceeaadcc47df99a0663a1e0b9 Mon Sep 17 00:00:00 2001 From: Georges Basile Stavracas Neto Date: Mon, 30 Dec 2019 14:03:15 -0300 Subject: [PATCH] details-page: Protect against NULL line On a Raspberry PI 4, Sysprof crashes immediately when trying to memchr() on the 'line' variable. The current RPI4 support is poor on Linux mainline admitedly, but having Sysprof to work on it at least gives us a chance to profile the major bottlenecks. Protect against NULL 'line'. --- src/libsysprof-ui/sysprof-details-page.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libsysprof-ui/sysprof-details-page.c b/src/libsysprof-ui/sysprof-details-page.c index 03963c55..daee5480 100644 --- a/src/libsysprof-ui/sysprof-details-page.c +++ b/src/libsysprof-ui/sysprof-details-page.c @@ -142,8 +142,12 @@ cpu_info_cb (const SysprofCaptureFrame *frame, const gchar *line; gchar **str = user_data; - endptr = (gchar *)fc->data + fc->len; line = memmem ((gchar *)fc->data, fc->len, "model name", 10); + + if (!line) + return FALSE; + + endptr = (gchar *)fc->data + fc->len; endptr = memchr (line, '\n', endptr - line); if (endptr)