From b048b78429b0de80b8c37b67fecb735e97422c55 Mon Sep 17 00:00:00 2001
From: Christian Hergert <chergert@redhat.com>
Date: Fri, 1 Apr 2022 13:39:44 -0700
Subject: [PATCH] libsysprof-ui: cleanup builder ui style a bit

We can remove lots of things and be more consistent with conventions.
---
 src/libsysprof-ui/sysprof-callgraph-page.ui   |  9 --
 src/libsysprof-ui/sysprof-memprof-page.ui     | 27 ------
 .../sysprof-visualizers-frame.ui              | 84 +++++--------------
 3 files changed, 22 insertions(+), 98 deletions(-)

diff --git a/src/libsysprof-ui/sysprof-callgraph-page.ui b/src/libsysprof-ui/sysprof-callgraph-page.ui
index 6a0343e7..b0dc4f26 100644
--- a/src/libsysprof-ui/sysprof-callgraph-page.ui
+++ b/src/libsysprof-ui/sysprof-callgraph-page.ui
@@ -2,24 +2,19 @@
   <template class="SysprofCallgraphPage" parent="SysprofPage">
     <child>
       <object class="GtkStack" id="stack">
-        <property name="visible">true</property>
         <child>
           <object class="EggPaned" id="callgraph">
             <property name="orientation">horizontal</property>
-            <property name="visible">true</property>
             <child>
               <object class="EggPaned">
                 <property name="orientation">vertical</property>
-                <property name="visible">true</property>
                 <property name="width-request">400</property>
                 <child>
                   <object class="GtkScrolledWindow">
-                    <property name="visible">true</property>
                     <property name="vexpand">true</property>
                     <child>
                       <object class="GtkTreeView" id="functions_view">
                         <property name="fixed-height-mode">true</property>
-                        <property name="visible">true</property>
                         <child>
                           <object class="GtkTreeViewColumn" id="function_name_column">
                             <property name="expand">true</property>
@@ -74,11 +69,9 @@
                 </child>
                 <child>
                   <object class="GtkScrolledWindow">
-                    <property name="visible">true</property>
                     <property name="vexpand">true</property>
                     <child>
                       <object class="GtkTreeView" id="callers_view">
-                        <property name="visible">true</property>
                         <child>
                           <object class="GtkTreeViewColumn" id="callers_name_column">
                             <property name="expand">true</property>
@@ -136,10 +129,8 @@
             <child>
               <object class="GtkScrolledWindow">
                 <property name="hexpand">true</property>
-                <property name="visible">true</property>
                 <child>
                   <object class="GtkTreeView" id="descendants_view">
-                    <property name="visible">true</property>
                     <child>
                       <object class="GtkTreeViewColumn" id="descendants_name_column">
                         <property name="expand">true</property>
diff --git a/src/libsysprof-ui/sysprof-memprof-page.ui b/src/libsysprof-ui/sysprof-memprof-page.ui
index 48d6e9da..eb6e8bc0 100644
--- a/src/libsysprof-ui/sysprof-memprof-page.ui
+++ b/src/libsysprof-ui/sysprof-memprof-page.ui
@@ -4,32 +4,27 @@
     <child>
       <object class="GtkBox">
         <property name="orientation">vertical</property>
-        <property name="visible">true</property>
         <child>
           <object class="GtkCenterBox">
             <property name="orientation">horizontal</property>
-            <property name="visible">true</property>
             <child type="center">
               <object class="GtkBox">
                 <property name="margin-top">6</property>
                 <property name="margin-bottom">6</property>
                 <property name="orientation">horizontal</property>
                 <property name="homogeneous">true</property>
-                <property name="visible">true</property>
                 <style>
                   <class name="linked"/>
                 </style>
                 <child>
                   <object class="GtkToggleButton" id="summary">
                     <property name="label" translatable="yes">Summary</property>
-                    <property name="visible">true</property>
                     <property name="active">false</property>
                   </object>
                 </child>
                 <child>
                   <object class="GtkToggleButton" id="all_allocs">
                     <property name="label" translatable="yes">All Allocations</property>
-                    <property name="visible">true</property>
                     <property name="group">summary</property>
                     <property name="active">true</property>
                   </object>
@@ -37,7 +32,6 @@
                 <child>
                   <object class="GtkToggleButton" id="temp_allocs">
                     <property name="label" translatable="yes">Temporary Allocations</property>
-                    <property name="visible">true</property>
                     <property name="active">false</property>
                     <property name="group">summary</property>
                   </object>
@@ -46,7 +40,6 @@
                   <object class="GtkRadioButton" id="leaked_allocs_button">
                     <property name="label" translatable="yes">Leaked Allocations</property>
                     <property name="draw-indicator">false</property>
-                    <property name="visible">true</property>
                     <property name="active">false</property>
                     <property name="group">summary</property>
                   </object>
@@ -58,16 +51,13 @@
         <child>
           <object class="GtkSeparator">
             <property name="orientation">horizontal</property>
-            <property name="visible">true</property>
           </object>
         </child>
         <child>
           <object class="GtkStack" id="stack">
-            <property name="visible">true</property>
             <child>
               <object class="GtkScrolledWindow" id="summary_page">
                 <property name="hscrollbar-policy">never</property>
-                <property name="visible">true</property>
                 <child>
                   <object class="GtkBox">
                     <property name="margin-top">16</property>
@@ -75,13 +65,11 @@
                     <property name="margin-start">16</property>
                     <property name="margin-end">16</property>
                     <property name="orientation">vertical</property>
-                    <property name="visible">true</property>
                     <child>
                       <object class="EggThreeGrid">
                         <property name="hexpand">true</property>
                         <property name="row-spacing">6</property>
                         <property name="column-spacing">18</property>
-                        <property name="visible">true</property>
                         <child>
                           <object class="GtkLabel">
                             <property name="label">Peak Allocation</property>
@@ -111,7 +99,6 @@
                           <object class="GtkLabel">
                             <property name="label">Number of Allocations</property>
                             <property name="halign">end</property>
-                            <property name="visible">true</property>
                             <style>
                               <class name="dim-label"/>
                             </style>
@@ -125,7 +112,6 @@
                           <object class="GtkLabel" id="num_allocs">
                             <property name="xalign">0</property>
                             <property name="selectable">true</property>
-                            <property name="visible">true</property>
                             <layout>
                               <property name="column">center</property>
                               <property name="row">1</property>
@@ -161,7 +147,6 @@
                           <object class="GtkLabel">
                             <property name="label">Temporary Allocations</property>
                             <property name="halign">end</property>
-                            <property name="visible">true</property>
                             <style>
                               <class name="dim-label"/>
                             </style>
@@ -176,7 +161,6 @@
                             <property name="xalign">0</property>
                             <property name="selectable">true</property>
                             <property name="width-chars">50</property>
-                            <property name="visible">true</property>
                             <layout>
                               <property name="column">center</property>
                               <property name="row">3</property>
@@ -188,7 +172,6 @@
                             <property name="label">Allocations by Size</property>
                             <property name="halign">end</property>
                             <property name="valign">start</property>
-                            <property name="visible">true</property>
                             <style>
                               <class name="dim-label"/>
                             </style>
@@ -200,10 +183,8 @@
                         </child>
                         <child>
                           <object class="GtkFrame">
-                            <property name="visible">true</property>
                             <child>
                               <object class="GtkListBox" id="by_size">
-                                <property name="visible">true</property>
                               </object>
                             </child>
                             <layout>
@@ -222,19 +203,15 @@
               <object class="EggPaned" id="callgraph">
                 <property name="orientation">horizontal</property>
                 <property name="vexpand">true</property>
-                <property name="visible">true</property>
                 <child>
                   <object class="EggPaned">
                     <property name="width-request">400</property>
                     <property name="orientation">vertical</property>
-                    <property name="visible">true</property>
                     <child>
                       <object class="GtkScrolledWindow">
-                        <property name="visible">true</property>
                         <child>
                           <object class="GtkTreeView" id="functions_view">
                             <property name="fixed-height-mode">true</property>
-                            <property name="visible">true</property>
                             <child>
                               <object class="GtkTreeViewColumn" id="function_name_column">
                                 <property name="expand">true</property>
@@ -290,10 +267,8 @@
                     </child>
                     <child>
                       <object class="GtkScrolledWindow">
-                        <property name="visible">true</property>
                         <child>
                           <object class="GtkTreeView" id="callers_view">
-                            <property name="visible">true</property>
                             <child>
                               <object class="GtkTreeViewColumn" id="callers_name_column">
                                 <property name="expand">true</property>
@@ -351,10 +326,8 @@
                 </child>
                 <child>
                   <object class="GtkScrolledWindow">
-                    <property name="visible">true</property>
                     <child>
                       <object class="GtkTreeView" id="descendants_view">
-                        <property name="visible">true</property>
                         <child>
                           <object class="GtkTreeViewColumn" id="descendants_name_column">
                             <property name="expand">true</property>
diff --git a/src/libsysprof-ui/sysprof-visualizers-frame.ui b/src/libsysprof-ui/sysprof-visualizers-frame.ui
index 70ff3f6b..1246b301 100644
--- a/src/libsysprof-ui/sysprof-visualizers-frame.ui
+++ b/src/libsysprof-ui/sysprof-visualizers-frame.ui
@@ -3,15 +3,12 @@
   <template class="SysprofVisualizersFrame" parent="GtkWidget">
     <child>
       <object class="GtkBox">
-        <property name="visible">True</property>
         <property name="orientation">vertical</property>
         <child>
           <object class="GtkBox">
-            <property name="visible">True</property>
             <child>
               <object class="GtkBox" id="box1">
                 <property name="width_request">125</property>
-                <property name="visible">True</property>
                 <property name="orientation">vertical</property>
                 <child>
                   <object class="GtkBox">
@@ -26,7 +23,6 @@
                     </style>
                     <child type="center">
                       <object class="GtkLabel">
-                        <property name="visible">True</property>
                         <property name="margin_start">6</property>
                         <property name="margin_end">6</property>
                         <property name="margin_top">3</property>
@@ -64,39 +60,33 @@
                 </child>
                 <child>
                   <object class="GtkSeparator">
-                    <property name="visible">True</property>
                   </object>
                 </child>
               </object>
             </child>
             <child>
               <object class="GtkSeparator">
-                <property name="visible">True</property>
                 <property name="orientation">vertical</property>
               </object>
             </child>
             <child>
               <object class="GtkBox" id="ticks_box">
-                <property name="visible">True</property>
-                <property name="vexpand">False</property>
+                <property name="vexpand">false</property>
                 <property name="orientation">vertical</property>
                 <child>
                   <object class="GtkScrolledWindow" id="ticks_scroller">
-                    <property name="visible">True</property>
-                    <property name="hexpand">True</property>
-                    <property name="vexpand">True</property>
-                    <property name="hscrollbar_policy">external</property>
-                    <property name="vscrollbar_policy">never</property>
+                    <property name="hexpand">true</property>
+                    <property name="vexpand">true</property>
+                    <property name="hscrollbar-policy">external</property>
+                    <property name="vscrollbar-policy">never</property>
                     <child>
                       <object class="GtkViewport" id="ticks_viewport">
-                        <property name="visible">True</property>
                         <property name="halign">start</property>
                         <style>
                           <class name="visualizers"/>
                         </style>
                         <child>
                           <object class="SysprofVisualizerTicks" id="ticks">
-                            <property name="visible">True</property>
                           </object>
                         </child>
                       </object>
@@ -105,7 +95,6 @@
                 </child>
                 <child>
                   <object class="GtkSeparator">
-                    <property name="visible">True</property>
                   </object>
                 </child>
               </object>
@@ -114,23 +103,19 @@
         </child>
         <child>
           <object class="GtkScrolledWindow" id="vscroller">
-            <property name="visible">True</property>
-            <property name="vexpand">True</property>
-            <property name="hscrollbar_policy">never</property>
-            <property name="propagate_natural_height">True</property>
+            <property name="vexpand">true</property>
+            <property name="hscrollbar-policy">never</property>
+            <property name="propagate-natural-height">true</property>
             <child>
               <object class="GtkViewport">
-                <property name="visible">True</property>
                 <child>
                   <object class="GtkBox">
                     <property name="orientation">horizontal</property>
-                    <property name="visible">True</property>
                     <child>
                       <object class="GtkListBox" id="groups">
                         <property name="width_request">125</property>
-                        <property name="visible">True</property>
-                        <property name="hexpand">False</property>
-                        <property name="selection_mode">single</property>
+                        <property name="hexpand">false</property>
+                        <property name="selection-mode">single</property>
                         <style>
                           <class name="left-column"/>
                           <class name="visualizer-groups"/>
@@ -139,30 +124,25 @@
                     </child>
                     <child>
                       <object class="GtkSeparator">
-                        <property name="visible">True</property>
                         <property name="orientation">vertical</property>
                       </object>
                     </child>
                     <child>
                       <object class="GtkScrolledWindow" id="hscroller">
-                        <property name="visible">True</property>
-                        <property name="hexpand">True</property>
-                        <property name="vexpand">True</property>
-                        <property name="hscrollbar_policy">external</property>
-                        <property name="vscrollbar_policy">never</property>
-                        <property name="propagate_natural_height">True</property>
+                        <property name="hexpand">true</property>
+                        <property name="vexpand">true</property>
+                        <property name="hscrollbar-policy">external</property>
+                        <property name="vscrollbar-policy">never</property>
+                        <property name="propagate-natural-height">true</property>
                         <child>
                           <object class="GtkViewport" id="visualizers_viewport">
-                            <property name="visible">True</property>
-                            <property name="halign">start</property>
                             <style>
                               <class name="visualizers"/>
                             </style>
                             <child>
                               <object class="GtkListBox" id="visualizers">
-                                <property name="visible">True</property>
                                 <property name="selection_mode">none</property>
-                                <property name="activate_on_single_click">False</property>
+                                <property name="activate_on_single_click">false</property>
                               </object>
                             </child>
                           </object>
@@ -177,37 +157,27 @@
         </child>
         <child>
           <object class="GtkSeparator">
-            <property name="visible">True</property>
           </object>
         </child>
         <child>
           <object class="GtkBox">
-            <property name="visible">True</property>
             <style>
               <class name="inline-toolbar"/>
             </style>
             <child>
               <object class="GtkBox" id="box2">
                 <property name="width_request">125</property>
-                <property name="visible">True</property>
                 <property name="margin-start">6</property>
                 <property name="margin-end">6</property>
-                <property name="hexpand">False</property>
+                <property name="hexpand">false</property>
                 <style>
                   <class name="left-column"/>
                 </style>
                 <child>
                   <object class="GtkButton" id="zoom_out">
                     <property name="action-name">zoom.zoom-out</property>
-                    <property name="visible">True</property>
-                    <property name="receives_default">True</property>
                     <property name="valign">center</property>
-                    <child>
-                      <object class="GtkImage">
-                        <property name="visible">True</property>
-                        <property name="icon_name">zoom-out-symbolic</property>
-                      </object>
-                    </child>
+                    <property name="icon_name">zoom-out-symbolic</property>
                     <style>
                       <class name="image-button"/>
                       <class name="small-button"/>
@@ -218,10 +188,9 @@
                 <child>
                   <object class="GtkScale" id="zoom_scale">
                     <property name="width_request">175</property>
-                    <property name="visible">True</property>
-                    <property name="hexpand">True</property>
+                    <property name="hexpand">true</property>
                     <property name="round_digits">1</property>
-                    <property name="draw_value">False</property>
+                    <property name="draw_value">false</property>
                     <marks>
                       <mark value="0.0" position="bottom"/>
                     </marks>
@@ -230,15 +199,8 @@
                 <child>
                   <object class="GtkButton" id="zoom_in">
                     <property name="action-name">zoom.zoom-in</property>
-                    <property name="visible">True</property>
-                    <property name="receives_default">True</property>
                     <property name="valign">center</property>
-                    <child>
-                      <object class="GtkImage">
-                        <property name="visible">True</property>
-                        <property name="icon_name">zoom-in-symbolic</property>
-                      </object>
-                    </child>
+                    <property name="icon-name">zoom-in-symbolic</property>
                     <style>
                       <class name="image-button"/>
                       <class name="small-button"/>
@@ -250,13 +212,11 @@
             </child>
             <child>
               <object class="GtkSeparator">
-                <property name="visible">True</property>
               </object>
             </child>
             <child>
               <object class="SysprofScrollmap" id="hscrollbar">
-                <property name="visible">True</property>
-                <property name="hexpand">True</property>
+                <property name="hexpand">true</property>
               </object>
             </child>
           </object>