Add commented out code to reject callback.

2008-02-17  Soren Sandmann  <sandmann@redhat.com>

	* collector.c (lookup_symbol): Add commented out code to reject
	callback.

	* elfparser.c (struct ElfParser): Store the filename if any
	(elf_parser_get_sym_address): Subtract the load address, so the
	result will be an offset into the text section.

	* process.[ch] (process_lookup_symbol): Add an offset out-argument
	
	* binfile.[ch] (bin_symbol_get_address): New function

	* TODO: updates



svn path=/trunk/; revision=397
This commit is contained in:
Soren Sandmann
2008-02-17 23:31:19 +00:00
committed by Søren Sandmann Pedersen
parent 9d2f7a1a9d
commit b98db05f9b
8 changed files with 100 additions and 18 deletions

13
TODO
View File

@ -44,7 +44,7 @@ Before 1.2:
- GObject signal emission overhead accounts for 18% of
the time.
Consider adding a forked version of GtkTreeStore with
performance fixes.
performance and bug fixes.
* Make sure that labels look decent in case of "No Map" etc.
@ -363,6 +363,17 @@ Before 1.2:
one can be completed using the DWARF information for
the shared part.
* Notes on heuristic stack walking
- We can reject addresses that point exactly to the beginning of a
function since these are likely callbacks. Note though that the
first time a function in a shared library is called, it goes
through dynamic linker resolution which will cause the stack to
contain a callback of the function. This needs to be investigated
in more detail.
- We are already rejecting addresses outside the text section
(addresses of global variables and the like).
* How to get the user stack: