From 8230ef951b66fc110a36131347bbd4566bfd8ee3 Mon Sep 17 00:00:00 2001
From: Automeris naranja <automerisnaranja@tutanota.com>
Date: Mon, 6 Mar 2023 11:22:30 -0300
Subject: [PATCH 1/2] window: Fix icon of the Main Menu button

Embedding a GtkImage inside the Main Menu button is
no longer necessary. Using the icon_name property already
does the trick.
---
 src/sysprof/sysprof-window.ui | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/sysprof/sysprof-window.ui b/src/sysprof/sysprof-window.ui
index 34888c48..60a397d1 100644
--- a/src/sysprof/sysprof-window.ui
+++ b/src/sysprof/sysprof-window.ui
@@ -20,12 +20,7 @@
                 <property name="tooltip-text" translatable="yes">Main Menu</property>
                 <property name="visible">true</property>
                 <property name="primary">true</property>
-                <child>
-                  <object class="GtkImage">
-                    <property name="icon-name">open-menu-symbolic</property>
-                    <property name="visible">true</property>
-                  </object>
-                </child>
+                <property name="icon-name">open-menu-symbolic</property>
                 <style>
                   <class name="image-button"/>
                 </style>

From b91fd26dbfdf4478afd156ef9df68bcf2cdfab94 Mon Sep 17 00:00:00 2001
From: Automeris naranja <automerisnaranja@tutanota.com>
Date: Mon, 6 Mar 2023 11:31:44 -0300
Subject: [PATCH 2/2] general: Remove "visible=true" properties

Widgets are shown by default in GTK4, so using
"visible=true" is no longer necessary.
---
 src/libsysprof-ui/sysprof-failed-state-view.ui    | 4 ----
 src/libsysprof-ui/sysprof-logs-page.ui            | 2 --
 src/libsysprof-ui/sysprof-process-model-row.ui    | 4 ----
 src/libsysprof-ui/sysprof-recording-state-view.ui | 8 --------
 src/libsysprof-ui/sysprof-visualizers-frame.ui    | 2 --
 src/sysprof/sysprof-window.ui                     | 3 ---
 6 files changed, 23 deletions(-)

diff --git a/src/libsysprof-ui/sysprof-failed-state-view.ui b/src/libsysprof-ui/sysprof-failed-state-view.ui
index 228512ee..8b01a009 100644
--- a/src/libsysprof-ui/sysprof-failed-state-view.ui
+++ b/src/libsysprof-ui/sysprof-failed-state-view.ui
@@ -11,12 +11,10 @@
         <property name="margin-end">36</property>
         <property name="orientation">vertical</property>
         <property name="spacing">12</property>
-        <property name="visible">true</property>
         <child type="center">
           <object class="GtkImage">
             <property name="icon-name">computer-fail-symbolic</property>
             <property name="pixel-size">256</property>
-            <property name="visible">true</property>
             <style>
               <class name="dim-label"/>
             </style>
@@ -25,7 +23,6 @@
         <child type="end">
           <object class="GtkLabel">
             <property name="label" translatable="yes">Ouch, that hurt!</property>
-            <property name="visible">true</property>
             <style>
               <class name="dim-label"/>
             </style>
@@ -39,7 +36,6 @@
           <object class="GtkLabel">
             <property name="label" translatable="yes">Something unexpectedly went wrong while trying to profile your system.</property>
             <property name="use-markup">true</property>
-            <property name="visible">true</property>
             <style>
               <class name="dim-label"/>
             </style>
diff --git a/src/libsysprof-ui/sysprof-logs-page.ui b/src/libsysprof-ui/sysprof-logs-page.ui
index 6760253a..2f4d565b 100644
--- a/src/libsysprof-ui/sysprof-logs-page.ui
+++ b/src/libsysprof-ui/sysprof-logs-page.ui
@@ -3,12 +3,10 @@
   <template class="SysprofLogsPage" parent="SysprofPage">
     <child>
       <object class="GtkScrolledWindow">
-        <property name="visible">true</property>
         <child>
           <object class="GtkTreeView" id="tree_view">
             <property name="tooltip-column">3</property>
             <property name="headers-visible">true</property>
-            <property name="visible">true</property>
             <child>
               <object class="GtkTreeViewColumn">
                 <property name="expand">false</property>
diff --git a/src/libsysprof-ui/sysprof-process-model-row.ui b/src/libsysprof-ui/sysprof-process-model-row.ui
index 721c26fe..ee23e296 100644
--- a/src/libsysprof-ui/sysprof-process-model-row.ui
+++ b/src/libsysprof-ui/sysprof-process-model-row.ui
@@ -3,7 +3,6 @@
   <template class="SysprofProcessModelRow" parent="GtkListBoxRow">
     <child>
       <object class="GtkBox">
-        <property name="visible">true</property>
         <property name="margin-start">6</property>
         <property name="margin-end">6</property>
         <property name="margin-top">6</property>
@@ -17,7 +16,6 @@
         <child>
           <object class="GtkLabel" id="label">
             <property name="hexpand">false</property>
-            <property name="visible">true</property>
             <property name="ellipsize">middle</property>
             <property name="xalign">0.0</property>
           </object>
@@ -25,7 +23,6 @@
         <child>
           <object class="GtkLabel" id="args_label">
             <property name="hexpand">false</property>
-            <property name="visible">true</property>
             <property name="ellipsize">end</property>
             <property name="xalign">0.0</property>
             <style>
@@ -43,7 +40,6 @@
         <child>
           <object class="GtkLabel" id="pid">
             <property name="hexpand">true</property>
-            <property name="visible">true</property>
             <property name="xalign">1.0</property>
             <style>
               <class name="dim-label"/>
diff --git a/src/libsysprof-ui/sysprof-recording-state-view.ui b/src/libsysprof-ui/sysprof-recording-state-view.ui
index d65da15b..1885f885 100644
--- a/src/libsysprof-ui/sysprof-recording-state-view.ui
+++ b/src/libsysprof-ui/sysprof-recording-state-view.ui
@@ -11,12 +11,10 @@
         <property name="margin-bottom">36</property>
         <property name="orientation">vertical</property>
         <property name="spacing">12</property>
-        <property name="visible">true</property>
         <child>
           <object class="GtkImage">
             <property name="icon-name">org.gnome.Sysprof-symbolic</property>
             <property name="pixel-size">256</property>
-            <property name="visible">true</property>
             <style>
               <class name="dim-label"/>
             </style>
@@ -24,7 +22,6 @@
         </child>
         <child>
           <object class="SysprofTimeLabel" id="elapsed">
-            <property name="visible">true</property>
             <style>
               <class name="dim-label"/>
             </style>
@@ -34,7 +31,6 @@
           <object class="GtkLabel">
             <property name="label" translatable="yes">Did you know you can use &lt;a href="help:sysprof"&gt;sysprof-cli&lt;/a&gt; to record?</property>
             <property name="use-markup">true</property>
-            <property name="visible">true</property>
             <style>
               <class name="dim-label"/>
             </style>
@@ -44,13 +40,11 @@
           <object class="GtkBox">
             <property name="orientation">horizontal</property>
             <property name="spacing">6</property>
-            <property name="visible">true</property>
             <child>
               <object class="GtkLabel">
                 <property name="label" translatable="yes">Events</property>
                 <property name="xalign">1.0</property>
                 <property name="valign">baseline</property>
-                <property name="visible">true</property>
                 <style>
                   <class name="dim-label"/>
                 </style>
@@ -59,7 +53,6 @@
             <child>
               <object class="GtkLabel" id="samples">
                 <property name="label">0</property>
-                <property name="visible">true</property>
                 <property name="hexpand">true</property>
                 <property name="valign">baseline</property>
                 <property name="xalign">0.0</property>
@@ -72,7 +65,6 @@
               <object class="GtkButton">
                 <property name="action-name">display.stop-recording</property>
                 <property name="margin-top">24</property>
-                <property name="visible">true</property>
                 <property name="label" translatable="yes">_Stop Recording</property>
                 <property name="halign">end</property>
                 <property name="width-request">125</property>
diff --git a/src/libsysprof-ui/sysprof-visualizers-frame.ui b/src/libsysprof-ui/sysprof-visualizers-frame.ui
index 88e09946..4ff60076 100644
--- a/src/libsysprof-ui/sysprof-visualizers-frame.ui
+++ b/src/libsysprof-ui/sysprof-visualizers-frame.ui
@@ -13,7 +13,6 @@
                 <child>
                   <object class="GtkCenterBox">
                     <property name="orientation">horizontal</property>
-                    <property name="visible">true</property>
                     <property name="margin-top">3</property>
                     <property name="margin-bottom">3</property>
                     <property name="margin-start">7</property>
@@ -48,7 +47,6 @@
                           <object class="GtkImage">
                             <property name="icon-name">preferences-system-details-symbolic</property>
                             <property name="pixel-size">16</property>
-                            <property name="visible">true</property>
                           </object>
                         </child>
                       </object>
diff --git a/src/sysprof/sysprof-window.ui b/src/sysprof/sysprof-window.ui
index 60a397d1..046cd194 100644
--- a/src/sysprof/sysprof-window.ui
+++ b/src/sysprof/sysprof-window.ui
@@ -14,11 +14,9 @@
         <child>
           <object class="GtkHeaderBar">
             <property name="show-title-buttons">true</property>
-            <property name="visible">true</property>
             <child type="end">
               <object class="GtkMenuButton" id="menu_button">
                 <property name="tooltip-text" translatable="yes">Main Menu</property>
-                <property name="visible">true</property>
                 <property name="primary">true</property>
                 <property name="icon-name">open-menu-symbolic</property>
                 <style>
@@ -32,7 +30,6 @@
                 <property name="action-name">app.open-capture</property>
                 <property name="use-underline">true</property>
                 <property name="tooltip-text" translatable="yes">Open Recording… (Ctrl+O)</property>
-                <property name="visible">true</property>
               </object>
             </child>
             <child type="end">