varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Factor out some stuff in their own functions.

Browse Source 
Sun Apr 17 00:20:41 2005  Soeren Sandmann  <sandmann@redhat.com>

        * sysprof.c (on_open_clicked): Factor out some stuff in their own
        functions.

        * sysprof.c (load_file): Idle handler to load files given on the
        command line.

        * sysprof.c (main): If a filename is passed on the command line,
        load it in an idle handler.
This commit is contained in:
Soeren Sandmann
2005-04-17 06:03:38 +00:00
committed by Søren Sandmann Pedersen
parent 023ce06615
commit c824b74b9d
3 changed files with 164 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
TODO
View File

@ -4,23 +4,18 @@ Before 1.0:
- grep FIXME
- When the module is unloaded, kill all processes blocking in read
- or block unloading until all processes have exited
- Find out what happened here:
- Hopefully the oops at the end of this file is gone now that
we use mmput/get_task_mm. For older kernels those symbols
are not exported though, so we will probably have to either
use the old way (directly accessing the mm's) or just not
support those kernels.
* Interface
- If the current profile has a name, display it in the title bar
- Sould just install the kernel module if it running as root, pop up
a dialog if not. Note we must be able to start without module now,
since it is useful to just load profiles from disk.
- Is there a portable way of asking for the root password?
- Install a small suid program that only inserts the module?
(instant security hole ..)
- hook up menu items view/start etc (or possibly get rid of them or
move them)
- Consider expanding a few more levels of a new descendants tree
- give profiles on the command line
* Build system
- Need to make "make install" work (how do you know where to install
@ -34,6 +29,10 @@ Before 1.0:
- .desktop file
- translation should be hooked up
Before 1.2:
- Make busy cursors more intelligent
@ -91,9 +90,6 @@ Before 1.2:
- speedprof seems to report that lots of time is spent in
stack_stash_foreach() and also in generate_key()
- add an 'everything' object. It is really needed for a lot of things
- make profile.c more agnostic to processes and functions etc. Ideally
it should just take a set of stack traces containing "presentation
objects" and do something sensible with it.
- Non-GUI version that can save in a format the GUI can understand.
Could be used for profiling startup etc. Would preferably be able to
@ -108,6 +104,9 @@ Before 1.2:
- possibly add dependency on glib 2.8 if it is released at that point.
(g_file_replace())
Later:
- Find out how to hack around gtk+ bug causing multiple double clicks
@ -196,8 +195,19 @@ Later:
been read will stay in cache (for short profile runs you can assume that with disk,
but not for long ones).
DONE:
- give profiles on the command line
- Hopefully the oops at the end of this file is gone now that
we use mmput/get_task_mm. For older kernels those symbols
are not exported though, so we will probably have to either
use the old way (directly accessing the mm's) or just not
support those kernels.
- Need an icon
- hook up about box
@ -297,6 +307,8 @@ It is possible that we simply need a better concept of Process:
- fix leaks
- Find out what happened here:
Apr 11 15:42:08 great-sage-equal-to-heaven kernel: Unable to handle kernel NULL pointer dereference at virtual address 000001b8
Apr 11 15:42:08 great-sage-equal-to-heaven kernel: printing eip:
Apr 11 15:42:08 great-sage-equal-to-heaven kernel: c017342c