varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-11 15:40:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

proc: ignore inode from podman processes

Browse Source 
They never appear to be right anyway, so they just get in the way of
decoding anything (for which we might get right with a CRC check later).
This commit is contained in:
Christian Hergert
2021-09-21 16:16:30 -07:00
parent 468b45b086
commit d641856317
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/libsysprof/sysprof-proc-source.c
View File

@ -80,7 +80,8 @@ sysprof_proc_source_populate_process (SysprofProcSource *self,
static void static void
sysprof_proc_source_populate_maps (SysprofProcSource *self, sysprof_proc_source_populate_maps (SysprofProcSource *self,
GPid pid, GPid pid,
const gchar *mapsstr) const gchar *mapsstr,
gboolean ignore_inode)
{ {
g_auto(GStrv) lines = NULL; g_auto(GStrv) lines = NULL;
@ -107,7 +108,7 @@ sysprof_proc_source_populate_maps (SysprofProcSource *self,
if (r != 5) if (r != 5)
continue; continue;
if (strcmp ("[vdso]", file) == 0) if (ignore_inode || strcmp ("[vdso]", file) == 0)
{ {
/* /*
* Søren Sandmann Pedersen says: * Søren Sandmann Pedersen says:
@ -307,6 +308,7 @@ sysprof_proc_source_populate (SysprofProcSource *self,
const gchar *mountinfo; const gchar *mountinfo;
const gchar *maps; const gchar *maps;
const gchar *cgroup; const gchar *cgroup;
gboolean ignore_inode;
gint32 pid; gint32 pid;
g_variant_dict_init (&dict, pidinfo); g_variant_dict_init (&dict, pidinfo);
@ -330,9 +332,14 @@ sysprof_proc_source_populate (SysprofProcSource *self,
if (!g_variant_dict_lookup (&dict, "cgroup", "&s", &cgroup)) if (!g_variant_dict_lookup (&dict, "cgroup", "&s", &cgroup))
cgroup = ""; cgroup = "";
/* Ignore inodes from podman/toolbox because they appear
* to always be wrong. We'll have to rely on CRC instead.
*/
ignore_inode = strstr (cgroup, "/libpod-") != NULL;
sysprof_proc_source_populate_process (self, pid, *cmdline ? cmdline : comm); sysprof_proc_source_populate_process (self, pid, *cmdline ? cmdline : comm);
sysprof_proc_source_populate_mountinfo (self, pid, mountinfo); sysprof_proc_source_populate_mountinfo (self, pid, mountinfo);
sysprof_proc_source_populate_maps (self, pid, maps); sysprof_proc_source_populate_maps (self, pid, maps, ignore_inode);
sysprof_proc_source_populate_overlays (self, pid, cgroup); sysprof_proc_source_populate_overlays (self, pid, cgroup);
skip: skip: