varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-10 23:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

sysprof: sort flamegraph alphabetically for X axis

Browse Source 
This is what flamegraph.pl does, and there is somewhat an expectation that
we match that.
This commit is contained in:
Christian Hergert
2023-08-24 11:21:28 -07:00
parent 4d6f0fe061
commit debd576c2e
1 changed files with 28 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/sysprof/sysprof-flame-graph.c
View File

@ -24,6 +24,8 @@
#include "sysprof-category-icon.h" #include "sysprof-category-icon.h"
#include "sysprof-color-iter-private.h" #include "sysprof-color-iter-private.h"
#include "sysprof-symbol-private.h"
#include "sysprof-flame-graph.h" #include "sysprof-flame-graph.h"
struct _SysprofFlameGraph struct _SysprofFlameGraph
@ -43,6 +45,16 @@ G_DEFINE_FINAL_TYPE (SysprofFlameGraph, sysprof_flame_graph, GTK_TYPE_WIDGET)
static GParamSpec *properties [N_PROPS]; static GParamSpec *properties [N_PROPS];
static int
compare_node (gconstpointer a,
gconstpointer b)
{
const SysprofCallgraphNode *node_a = *(const SysprofCallgraphNode * const *)a;
const SysprofCallgraphNode *node_b = *(const SysprofCallgraphNode * const *)b;
return strcmp (node_a->summary->symbol->name, node_b->summary->symbol->name);
}
static void static void
sysprof_flame_graph_snapshot_node (GtkSnapshot *snapshot, sysprof_flame_graph_snapshot_node (GtkSnapshot *snapshot,
SysprofCallgraphNode *node, SysprofCallgraphNode *node,
@ -78,18 +90,31 @@ sysprof_flame_graph_snapshot_node (GtkSnapshot *snapshot,
if (node->children != NULL) if (node->children != NULL)
{ {
SysprofCallgraphNode **children;
graphene_rect_t child_area; graphene_rect_t child_area;
guint64 weight = 0; guint64 weight = 0;
guint n_children = 0;
guint i = 0;
child_area.origin.x = area->origin.x; child_area.origin.x = area->origin.x;
child_area.origin.y = area->origin.y; child_area.origin.y = area->origin.y;
child_area.size.height = area->size.height - row_height; child_area.size.height = area->size.height - row_height;
for (SysprofCallgraphNode *child = node->children; child; child = child->next)
weight += child->count;
for (SysprofCallgraphNode *child = node->children; child; child = child->next) for (SysprofCallgraphNode *child = node->children; child; child = child->next)
{ {
weight += child->count;
n_children++;
}
children = g_alloca (sizeof (SysprofCallgraphNode *) * n_children);
for (SysprofCallgraphNode *child = node->children; child; child = child->next)
children[i++] = child;
qsort (children, n_children, sizeof (SysprofCallgraphNode *), compare_node);
for (i = 0; i < n_children; i++)
{
SysprofCallgraphNode *child = children[i];
double ratio = child->count / (double)weight; double ratio = child->count / (double)weight;
double width; double width;