varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof-capture: Use libc string functions rather than GLib ones

Browse Source 
Use `strcmp()` and `strdup()` rather than `g_strcmp0()` and
`g_strdup()`. In the latter case, this makes no difference. In the
former case it means we potentially need to do some additional `NULL`
checks before calling it; although most of the call sites use
fixed-length arrays, so no `NULL` check is needed.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #40
This commit is contained in:
Philip Withnall
2020-07-01 17:45:09 +01:00
parent 1d865c5c8e
commit e26eae5bcf
3 changed files with 33 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/libsysprof-capture/sysprof-capture-condition.c
View File

@ -199,7 +199,10 @@ sysprof_capture_condition_match (const SysprofCaptureCondition *self,
if (frame->type != SYSPROF_CAPTURE_FRAME_FILE_CHUNK)
return false;
return g_strcmp0 (((const SysprofCaptureFileChunk *)frame)->path, self->u.where_file) == 0;
if (self->u.where_file == NULL)
return false;
return strcmp (((const SysprofCaptureFileChunk *)frame)->path, self->u.where_file) == 0;
default:
break;
@ -301,7 +304,7 @@ sysprof_capture_condition_finalize (SysprofCaptureCondition *self)
break;
case SYSPROF_CAPTURE_CONDITION_WHERE_FILE:
g_free (self->u.where_file);
free (self->u.where_file);
break;
default:
@ -518,7 +521,12 @@ sysprof_capture_condition_new_where_file (const char *path)
return NULL;
self->type = SYSPROF_CAPTURE_CONDITION_WHERE_FILE;
self->u.where_file = g_strdup (path);
self->u.where_file = strdup (path);
if (self->u.where_file == NULL)
{
free (self);
return NULL;
}
return self;
}