varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2025-12-31 20:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof-capture: Use libc string functions rather than GLib ones

Browse Source 
Use `strcmp()` and `strdup()` rather than `g_strcmp0()` and
`g_strdup()`. In the latter case, this makes no difference. In the
former case it means we potentially need to do some additional `NULL`
checks before calling it; although most of the call sites use
fixed-length arrays, so no `NULL` check is needed.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #40
This commit is contained in:
Philip Withnall
2020-07-01 17:45:09 +01:00
parent 1d865c5c8e
commit e26eae5bcf
3 changed files with 33 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/libsysprof-capture/sysprof-capture-reader.c
View File

@ -127,7 +127,7 @@ sysprof_capture_reader_finalize (SysprofCaptureReader *self)
{
close (self->fd);
free (self->buf);
g_free (self->filename);
free (self->filename);
free (self);
}
}
@ -283,7 +283,7 @@ sysprof_capture_reader_new (const char *filename,
return NULL;
}
self->filename = g_strdup (filename);
self->filename = strdup (filename);
return self;
}
@ -1086,7 +1086,7 @@ sysprof_capture_reader_save_as (SysprofCaptureReader *self,
}
if (self->filename == NULL)
self->filename = g_strdup (filename);
self->filename = strdup (filename);
close (fd);
@ -1179,7 +1179,7 @@ sysprof_capture_reader_copy (SysprofCaptureReader *self)
*copy = *self;
copy->ref_count = 1;
copy->filename = g_strdup (self->filename);
copy->filename = strdup (self->filename);
copy->fd = fd;
copy->end_time = self->end_time;
copy->st_buf = self->st_buf;
@ -1189,7 +1189,7 @@ sysprof_capture_reader_copy (SysprofCaptureReader *self)
if (copy->buf == NULL)
{
close (fd);
g_free (copy->filename);
free (copy->filename);
free (copy);
return NULL;
}
@ -1337,7 +1337,7 @@ sysprof_capture_reader_read_file_fd (SysprofCaptureReader *self,
if (!(file = sysprof_capture_reader_read_file (self)))
return false;
if (g_strcmp0 (path, file->path) != 0)
if (strcmp (path, file->path) != 0)
goto skip;
buf = file->data;
@ -1399,7 +1399,7 @@ sysprof_capture_reader_find_file (SysprofCaptureReader *self,
if (!(fc = sysprof_capture_reader_read_file (self)))
break;
if (g_strcmp0 (path, fc->path) == 0)
if (strcmp (path, fc->path) == 0)
return fc;
continue;