varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-09 22:50:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use APPLICATION_NAME macro

Browse Source 
Mon Oct 31 00:22:58 2005  Soeren Sandmann  <sandmann@redhat.com>

	* sysprof.c (set_application_title): Use APPLICATION_NAME macro

	* sysprof.c (load_file): Don't leak the FileOpenData

	* TODO: updates
This commit is contained in:
Soeren Sandmann
2005-10-31 05:20:37 +00:00
committed by Søren Sandmann Pedersen
parent c34a9b862f
commit ec8798a8b1
3 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
Mon Oct 31 00:22:58 2005 Soeren Sandmann <sandmann@redhat.com>
* sysprof.c (set_application_title): Use APPLICATION_NAME macro
* sysprof.c (load_file): Don't leak the FileOpenData
* TODO: updates
2005-10-30 Soren Sandmann <sandmann@redhat.com> 2005-10-30 Soren Sandmann <sandmann@redhat.com>
* configure.ac, Makefile.am: Don't link sysprof-text to gtk+. * configure.ac, Makefile.am: Don't link sysprof-text to gtk+.

4
TODO
View File

@ -37,7 +37,7 @@ Before 1.2:
"main"s are present, only one gets listed in the object list. "main"s are present, only one gets listed in the object list.
- Numbers in caller view are completely screwed up. - Numbers in caller view are completely screwed up.
- It looks like it sometimes gets confused with similar but different - It looks like it sometimes gets confused with similar but different
processess: Something like: processes: Something like:
process a spends 80% in foo() called from bar() process a spends 80% in foo() called from bar()
process b spends 1% in foo() called from baz() process b spends 1% in foo() called from baz()
we get reports of baz() using > 80% of the time. we get reports of baz() using > 80% of the time.
@ -52,7 +52,7 @@ Before 1.2:
- a more pragmatic approach might be to just walk the tree and - a more pragmatic approach might be to just walk the tree and
save it. save it.
- make stasckstash ref counted - make stackstash ref counted
- plug all the leaks - plug all the leaks
- don't leak the presentation strings/objects - don't leak the presentation strings/objects

5
sysprof.c
View File

@ -271,7 +271,7 @@ set_application_title (Application *app,
else else
{ {
gtk_window_set_title (GTK_WINDOW (app->main_window), gtk_window_set_title (GTK_WINDOW (app->main_window),
"System Collector"); APPLICATION_NAME);
} }
} }
@ -1331,6 +1331,8 @@ load_file (gpointer data)
g_error_free (err); g_error_free (err);
} }
g_free (file_open_data);
return FALSE; return FALSE;
} }
@ -1351,7 +1353,6 @@ main (int argc, char **argv)
if (argc > 1) if (argc > 1)
{ {
FileOpenData *file_open_data = g_new0 (FileOpenData, 1); FileOpenData *file_open_data = g_new0 (FileOpenData, 1);
file_open_data->filename = argv[1]; file_open_data->filename = argv[1];
file_open_data->app = app; file_open_data->app = app;