varun-r-mallya/sysprof
1
0
Fork 0
mirror of https://github.com/varun-r-mallya/sysprof.git synced 2026-02-10 23:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsysprof-analyze: apply text_offset for elfparser

Browse Source 
We need to do what binfile was doing and make the address relative to the
text_offset. We also need to ignore the text offset of the debuglink files
and pass it the text_offset of the original ELF.

This fixes a bunch of symbolization in the callgraph.
This commit is contained in:
Christian Hergert
2023-05-25 12:54:02 -07:00
parent c5f4d64a4c
commit ed0fefc721
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/libsysprof-analyze/sysprof-elf.c
View File

@ -33,6 +33,7 @@ struct _SysprofElf
SysprofElf *debug_link_elf; SysprofElf *debug_link_elf;
ElfParser *parser; ElfParser *parser;
guint64 file_inode; guint64 file_inode;
gulong text_offset;
}; };
enum { enum {
@ -308,6 +309,7 @@ sysprof_elf_new (const char *filename,
self->file = g_strdup (filename); self->file = g_strdup (filename);
self->parser = g_steal_pointer (&parser); self->parser = g_steal_pointer (&parser);
self->file_inode = file_inode; self->file_inode = file_inode;
self->text_offset = elf_parser_get_text_offset (self->parser);
if (filename != NULL) if (filename != NULL)
{ {
@ -357,7 +359,8 @@ sysprof_elf_get_symbol_at_address_internal (SysprofElf *self,
const char *filename, const char *filename,
guint64 address, guint64 address,
guint64 *begin_address, guint64 *begin_address,
guint64 *end_address) guint64 *end_address,
guint64 text_offset)
{ {
const ElfSym *symbol; const ElfSym *symbol;
char *ret = NULL; char *ret = NULL;
@ -368,18 +371,22 @@ sysprof_elf_get_symbol_at_address_internal (SysprofElf *self,
if (self->debug_link_elf != NULL) if (self->debug_link_elf != NULL)
{ {
ret = sysprof_elf_get_symbol_at_address_internal (self->debug_link_elf, filename, address, begin_address, end_address); ret = sysprof_elf_get_symbol_at_address_internal (self->debug_link_elf, filename, address, begin_address, end_address, text_offset);
if (ret != NULL) if (ret != NULL)
return ret; return ret;
} }
if ((symbol = elf_parser_lookup_symbol (self->parser, address))) if ((symbol = elf_parser_lookup_symbol (self->parser, address - text_offset)))
{ {
const char *name; const char *name;
if (begin_address || end_address) if (begin_address || end_address)
elf_parser_get_sym_address_range (self->parser, symbol, &begin, &end); {
elf_parser_get_sym_address_range (self->parser, symbol, &begin, &end);
begin += text_offset;
end += text_offset;
}
name = elf_parser_get_sym_name (self->parser, symbol); name = elf_parser_get_sym_name (self->parser, symbol);
@ -414,7 +421,8 @@ sysprof_elf_get_symbol_at_address (SysprofElf *self,
self->file, self->file,
address, address,
begin_address, begin_address,
end_address); end_address,
self->text_offset);
} }
/** /**